Skip to content

parallelFor, forAllRanged: take the progress callback by const reference #7151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fedr merged 1 commit into from
Oct 15, 2026
+4 −4
Merged

parallelFor, forAllRanged: take the progress callback by const reference #7151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/MRMesh/MRBitSetParallelFor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void forAllRanged( const Range & bitRange, FunctionRef<void ( size_t, const Rang
}

bool forAllRanged( const Range & bitRange, FunctionRef<void ( size_t, const Range &, void* )> f,
FunctionRef<void* ()> ctx, ProgressCallback progressCb, size_t reportProgressEveryBit )
FunctionRef<void* ()> ctx, const ProgressCallback& progressCb, size_t reportProgressEveryBit )
{
if ( !progressCb )
{
Expand Down
2 changes: 1 addition & 1 deletion source/MRMesh/MRBitSetParallelFor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ MRMESH_API void forAllRanged( const Range & bitRange, FunctionRef<void ( size_t,
FunctionRef<void* ()> ctx );

MRMESH_API bool forAllRanged( const Range & bitRange, FunctionRef<void ( size_t, const Range &, void* )> f,
FunctionRef<void* ()> ctx, ProgressCallback progressCb, size_t reportProgressEveryBit = 1024 );
FunctionRef<void* ()> ctx, const ProgressCallback& progressCb, size_t reportProgressEveryBit = 1024 );

template <typename BS, typename F, typename ...Cb>
auto ForAllRanged( const BS & bs, F && f, Cb && ... cb )
Expand Down
2 changes: 1 addition & 1 deletion source/MRMesh/MRParallelFor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void parallelFor( size_t begin, size_t end, FunctionRef<void ( size_t, void* )>
}

bool parallelFor( size_t begin, size_t end, FunctionRef<void ( size_t, void* )> f, FunctionRef<void* ()> ctx,
ProgressCallback cb, size_t reportProgressEvery )
const ProgressCallback& cb, size_t reportProgressEvery )
{
if ( !cb )
{
Expand Down
2 changes: 1 addition & 1 deletion source/MRMesh/MRParallelFor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ MRMESH_API void parallelFor( size_t begin, size_t end, FunctionRef<void ( size_t
MRMESH_API void parallelFor( size_t begin, size_t end, FunctionRef<void ( size_t, void* )> f, FunctionRef<void* ()> ctx );

MRMESH_API bool parallelFor( size_t begin, size_t end, FunctionRef<void ( size_t, void* )> f, FunctionRef<void* ()> ctx,
ProgressCallback cb, size_t reportProgressEvery = 1024 );
const ProgressCallback& cb, size_t reportProgressEvery = 1024 );

/// executes given function f for each span element [begin, end);
/// optional parameters after f: ProgressCallback cb, size_t reportProgressEvery = 1024 for periodic progress report
Expand Down
Loading