Repository navigation
Java: shorter test output paths, ffi class names truncated too - #59
Merged
Merged
Conversation
…racters The committed test outputs had paths up to 177 characters, 22 more than the Rust ones; a MeshInspector Windows runner checking out MeshLib's mrbind submodule went over MAX_PATH. The ffi classes are named after the C files, which the C generator truncates at 100 plus a hash, so they escaped the Java limit. The tests now pass --max-class-name-length 64 (max path 141). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
adalisk-emikhaylov
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeshInspector's Windows CI checks out MeshLib's
thirdparty/mrbindsubmodule underC:\actions-runner\_work\MeshInspectorCode\MeshInspectorCode\MeshLib\thirdparty\mrbind\(86 characters), and after #55 git failed there withFilename too long: the committed Java test outputs have paths up to 177 characters, 263 in total, over Windows' 260. The Rust outputs top out at 155.Two things made the Java paths longer than the others: the packages add
mrbind_test/mr/cs/to the file name, and thefficlasses are named after the C files, which the C generator already truncates at 100 characters plus a hash, so--max-class-name-length(also 100) never applied to them.fficlass names now go through the same truncation as the other classes.test/make_java.shpasses--max-class-name-length 64, which makes the longest test path 141 characters. The default stays 100, since MeshLib'sstd_function_...names are used directly by users.The default limit is a MeshLib-side concern too:
source/MeshLibJava/src/meshlib/mr/is shorter than the test directories, so MeshLib's longest path is ~150.🤖 Generated with Claude Code