docs: record the IH conformance fixes in the DCP test plan - #20
Merged
Conversation
eclipse-edc/IdentityHub#1063 closes nine of the cases this plan had open: CS-STOR-05 and RT-03 (the REJECTED CredentialMessage path, previously unimplemented on both sides), CS-PRES-11 (the vc.id scope alias), IS-META-02 (CredentialObject completeness and stability), IS-OFF-03 (per-offer reasons), CS-PRES-12 and CS-PRES-13, and TOK-09 and TOK-11. Those rows are green with their Notes naming the pull request, so they can be read back to amber if it does not land. Two of the fixes were not gaps this plan had identified, and both are recorded in the summary because a BYOW Credential Service can get them wrong the same way. The holder's Storage and Offer APIs resolved a signing key from the DID in the token's kid header while identifying the sender by its iss claim, with nothing binding the two, which let any resolvable DID pass the trusted-issuer check as somebody else. And published DID documents declared no verification relationships at all, so no generated presentation satisfied §5.4.3. TOK-10 moves from unknown to blocked: the upstream DidDocument model has no capabilityInvocation property, so IH can neither publish nor enforce the relationship. RT-06's note now says the key rotation e2e exists but is disabled pending its own runtime. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXL1LjCxfNnVtKkQFShci9
wolf4ood
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #18. eclipse-edc/IdentityHub#1063 closes nine of the cases this plan had open, so the IH column moves to 2 ❌, 3⚠️ from 5 and 9.
Those rows are green with their Notes naming the pull request, and the legend says so, so they can be read back to amber if it does not land.
Closed by that PR
REJECTEDCredentialMessagepath did not exist on either side: the Issuer only ever sentstatus: ISSUED, and the holder acknowledged a rejection with a 200 and then left the request waiting.vc.idscope alias is a spec MUST and was unimplemented; the scope tokenizer rejected it as malformed.credentialSchemawas absent from the model, the transformers and the vendored JSON-LD context, which had drifted behind the published one.issuancePolicyalso carried a fresh UUID per request, so cached objects differed between fetches.reissue.Two findings worth the DIV assessment's attention
Neither was a gap this plan had identified. Both are recorded in §9 because a BYOW Credential Service can get them wrong the same way:
kidheader while identifying the sender by itsissclaim, with nothing binding the two. Any holder of a resolvable DID could sign aCredentialMessageclaiming to come from a trusted issuer — the trusted-issuer check compares againstiss, so it passed.authentication.Worth asking whether DIV binds
kidtoiss, and what its DID documents declare.Status changes that are not fixes
DidDocumentmodel has nocapabilityInvocationproperty, so IH can neither publish nor enforce the relationship. This is a Connector-level gap, and it may be worth confirming whether any implementation in the ecosystem enforces the requirement today.The Priorities lists are untouched — they describe enhanced tests the TCK still needs, which IH's implementation status does not change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QXL1LjCxfNnVtKkQFShci9