Repository navigation
Delete the mcode opt-in and dead helpers - #499
Merged
Merged
Conversation
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes a setting that gated nothing, plus helpers with no production caller.
OAC_RUNTIME_MCODE_AGENTS_APIwas set to 1 by every producer: the native installer, the Runtime image and the integration test. Discovery already rejects every native version other thanSupportedVersion.SupportsExecutionis deleted, and an available mcode now declares its execution capabilities directly. The README, Dockerfile and installer environment drop the variable; the Dockerfile also dropsOAC_RUNTIME_MCODE_WORKSPACE=managed, which nothing reads.deadcodereported these unreachable, and a repo-wide grep (all modules) confirmed it:installroot.Lock, clienvironmentPathsOverlap, daemonizeMustWriteLine,paths.SessionsFile,api.ParseInstallationConfiguration,v1.ValidateModelProtocol,sandbox.lowerHex,e2b.New,microsandbox.New, and the unused obs/log API (Info/Error/Debug/ChildSpan/Discard,ctxLogger.Debug/With,Carrier.ChildSpan, and the unusedopargument ofStartBackgroundTrace);WritePIDFile/IsAlive,localworkspace.Newandnode.LoadIdentitytests now build the value directly, andruntimegateway.NewSessionmoves intosession_test.go.providerassets.Catalog(Web),microsandbox.Labels(themicrosandbox-providermodule), and thecoreErrorResponsemarker. Codex and Claude SDK leftovers are cleaned up on the agent-outside-sandbox branch, which rewrites those adapters.preparationState.workspaceReadOnlyalways equalledexecutor == nil, so the field is deleted.Checks:
go build ./...(plus windows/darwin for./apps/daemon/...); vet across the daemon,internal, Core, contracts and Web; build and vet themicrosandbox-providermodule.go testfor the 15 touched packages, and-racefor dispatch.make check-runtime-contract check-harness-catalog check-docs,check-names.py.deadcodenow lists only the claudesdkprepare(owned by the feature branch) and the two kept items above.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.