Repository navigation
Derive idle suspension from the checkpoint declaration - #538
Merged
Merged
Conversation
Core owns one idle suspension policy (300 seconds idle, 86400 seconds retention) and reports it for every Provider that declares checkpoint support. The microsandbox registry constant, its copy in the provider description and the idle_seconds/retention_seconds deployment columns are deleted; migration 000094 drops the columns and rewrites runtime_deployment_setup_check without them. Registration keeps only the declared rule that checkpoint support needs a nodes registration. The API suspension shape is unchanged; its description names the declaration rule instead of a vendor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idle suspension is now one Core policy: 300 seconds idle and 86400 seconds snapshot retention. Core applies it to every Provider that declares checkpoint support. Before this change it was a microsandbox constant in the Provider registry, copied into two deployment columns and read back.
IdleSeconds/RetentionSeconds, andsandbox.Descriptionno longer copies them. Registration keeps only the declared rule "checkpoint support ⇒nodesmode".runtime_deployment.idle_seconds/retention_secondsand rewritesruntime_deployment_setup_checkwithout them. Down restores the old columns and values.deployment.ServicederivesView.SuspensionandSetup.Suspensionfrom the checkpoint declaration in one helper.suspensionkeeps its shape. Its description now names the declaration rule, not a vendor.docs/sandbox-provider.md(en and zh) states the nodes-only rule and owns the values.sandbox-deployment.mdlinks to them.Production behaviour is unchanged.
Checks run locally:
go buildandgo vet;executionpackage and the wholetests/integrationpackage (370 tests);This is architecture alignment T5c (decision D2). It got no blind review, because it is a small deletion lane with no behaviour change.
Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.