Repository navigation
Require the installation ID and credential key - #541
Merged
Merged
Conversation
SaladDay
force-pushed
the
refactor/required-installation-files
branch
from
October 8, 2026 02:56
00972e5 to
541b422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core now always runs with an installation ID and a credential key. The run modes without them are deleted.
processconfig.Loadrequires both files, andOAC_PUBLIC_URLwith them. A missing file is a typed configuration error thatoac check-configreports.mainalways builds the sandbox manager.credential_storage_unavailable, and the "not configured" 503s. Constructors take a required key or ID. Tests sharepgtest.CredentialKey.installation_idinGET /core/v1/installationis a required string (make openapi;admin-api.mden and zh). Web's null branches are gone.official_client.pyuses a fixed test UUID, and the README tells developers to keep the ID and key with their database.execution_unavailable. The recovery path invaults.md(en and zh): Reset deployment and set up again. Leftover E2B sandboxes expire under their E2B timeout.configuration.md,vaults.md,admin-api.md,sessions-events,runtime-observabilityand IMPLEMENTATION.md, en and zh where they exist.Net lines: non-test −283, test −303.
Checks:
go build,go vet,make openapi(no diff); Go tests for every changed and dependent package against a database, includingcmd/server,api,execution,processconfig,sandbox/providersandtests/integration; Web and agents-client typecheck and the touched vitest files; docs build, translations andmake check-docs. The acceptance scripts changed, so this PR waits for CI before merging.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.