Repository navigation
Align Web design notes with Provider declarations - #542
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the batched review of #539 and #540.
apps/web/DESIGN.md: Add node no longer repeats the docker-group warning. It is stated once, in Use Docker instead of microsandbox?. Clean up the host no longer carries the microsandbox note, because the uninstaller prints what it keeps.docs/sandbox-provider.md(en and zh): the known design gap lists every place Web still names providers, including E2B's configuration fields in the deployment summary and in the client's deployment projection.provider_unavailableandhost_unsupported(en and zh): adds that a manually registered node logs the local error, because those nodes have no install command to rerun.Checks: Web typecheck;
sandbox-diagnosticandlocalevitest; the translation test;make check-docs.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.