Repository navigation
docs: state that npm adds provenance to releases of the public repository - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docs/releasing.mdand the comment onnpm publishinrelease-please.ymlstill say the repository is private and npm therefore creates no provenance. The repository is public, and every version since 0.1.1 carries an SLSA provenance attestation.What
docs/releasing.md: npm adds provenance to every trusted publish on its own; only 0.1.0, the manual first publish, has none.release-please.yml: the comment onnpm publishgives the same reason for not passing--provenance.Verification
npm view @miragon/bpmn-cli@<v> dist.attestations.provenance.predicateType:https://slsa.dev/provenance/v1for 0.1.1 and 0.8.0, nothing for 0.1.0.Part of #19 (serving the plugin from released commits stays open).