Repository navigation
refactor(cli)!: remove shell completion - #493
Merged
emaarco merged 1 commit intoOct 28, 2026
Merged
Conversation
Drop `pulse-cli completion bash|zsh|fish`, the hidden `pulse-cli __complete`, the completion metadata on commands and options, their tests, the docs section and the completion install of the Homebrew formula. `--help`, `describe` and `guide` are unchanged. BREAKING CHANGE: `pulse-cli completion` is gone and the Homebrew formula no longer installs a completion script, so Tab completion stops working in a plain shell after upgrading.
✅ Deploy Preview for spectacular-cobbler-f6c85b ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emaarco
marked this pull request as ready for review
October 28, 2026 07:43
emaarco
enabled auto-merge (squash)
October 28, 2026 07:43
emaarco
deleted the
emaarco/refactor-remove-shell-completion-from-pulse-cli
branch
October 28, 2026 07:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Shell completion cost about 640 lines of code and 750 lines of tests, and every new option had to work in three shells. Agents never press Tab, terminals like Warp complete on their own, and people mostly reach the engines through the VS Code extension or the chat widgets.
What
pulse-cli completion <bash|zsh|fish>and the hiddenpulse-cli __completewith their modules (completion-meta,completion-model,docs/completion,docs/completion-scripts) and tests.setPositional/setOptionCompletioncalls in the commands, theCOMPLETIONSmap andglobalOptionObjects()inglobals.ts,CompletableDoc/pathOfinoptions.ts, the profile value map inconfig.ts, thecomplete/suggestfields andCONDITIONSof the workflow option docs (WorkflowOptionDocis now plainOptionDoc), andWORKFLOW_COMMANDS, which only completion read.completion(root help, registration, help texts, command lines, workflow names, pack suite) and remove the completion cases inbearer.test.tsandproject.test.ts.generate_completions_from_executable.docs/cli/installation.mdand the mentions indocs/cli/index.md,docs/cli/development.md,apps/cli/README.mdandapps/cli/CLAUDE.md.--help,describeandguidebehave as before.Verification
pnpm build && pnpm typecheck && pnpm test && pnpm lintgreen (knip flagged the orphanedWORKFLOW_COMMANDS, which is removed).git grep -E "__complete|completion-(meta|model|scripts)|setPositional|setOptionCompletion|COMPLETION_SCRIPTS|generate_completions|shell completion"is empty.pulse-cli completion bashandpulse-cli __complete procexit 2 withUnknown command;pulse-cli --helpandpulse-cli describe task completeprint as before.test:enginesand the pack suite (pack.it.test.ts, one case removed); CI runs them.Breaking changes
pulse-cli completionis gone and the Homebrew formula no longer installs a completion script, so Tab completion stops working in a plain shell after upgrading. A completion script installed by hand earlier callspulse-cli __complete, which now fails, so remove it from~/.bashrc,~/.zfuncor~/.config/fish/completions. The commit carries aBREAKING CHANGE:footer for the release-please changelog.Closes #490