Repository navigation
docs: record Portugal's source coverage now that its OSM addresses are indexed - #237
Merged
Merged
Conversation
Speed, full index: SuggestAddress slower, p50 +12% (limit +10%)SearchAddressTime in ms over 1995 cases, each the fastest of 3 requests.
SuggestAddressTime in ms over 1996 checks, each the fastest of 3 requests.
ReverseGeocodeTime in ms over 1990 cases, each the fastest of 3 requests.
Fails when the total, p50, p90 or p99 of any table is more than 10% slower. Runs of one binary differ by up to 5%; the max is one request and only reported. Base |
Gold check, full index: no regressions
Runs
Landmark checks (head)
|
Mokto
force-pushed
the
fix/index-portugal-osm-addresses
branch
from
October 20, 2026 15:40
345f198 to
1b273b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs only. The Portugal triage note said Portuguese OpenStreetMap addresses never reach the index. That stopped being true when #233 and #240 merged, so the "Source coverage" section now describes the current state and the effect of adding Portugal's extract. The "Still open without a country" paragraph also links its tracking issue.
Changes
docs/evaluation/triage/portugal.mdto link fix: index OSM addresses for Chile, Colombia, Mexico, Portugal and Taiwan #233, fix: build moved OSM extracts from the other list's sealed mirror #240 andosm-address-countries.md, which already holds the coverage and panel numbers.9d4006a4eec15abb, consumer43cc3e8) adds 673,737 OSM address rows and 370,149 Portuguese houses (2,514,810 to 2,884,959).Lote 5 Bairro das Chancas).Review focus
Check that the numbers and the #233/#240 description match what those PRs did. There is no code or chart change, so the gold run should show no change.
Refs #222