Skip to content

docs: record Portugal's source coverage now that its OSM addresses are indexed - #237

Merged
Mokto merged 1 commit into
mainfrom
fix/index-portugal-osm-addresses
Oct 20, 2026
Merged

Mokto merged 1 commit into
mainfrom
fix/index-portugal-osm-addresses

Conversation

@Mokto

@Mokto Mokto commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Docs only. The Portugal triage note said Portuguese OpenStreetMap addresses never reach the index. That stopped being true when #233 and #240 merged, so the "Source coverage" section now describes the current state and the effect of adding Portugal's extract. The "Still open without a country" paragraph also links its tracking issue.

Changes

  • Rewrote "Source coverage" in docs/evaluation/triage/portugal.md to link fix: index OSM addresses for Chile, Colombia, Mexico, Portugal and Taiwan #233, fix: build moved OSM extracts from the other list's sealed mirror #240 and osm-address-countries.md, which already holds the coverage and panel numbers.
  • Added what that doc lacks: a world build with only Portugal's extract added (builder 9d4006a4eec15abb, consumer 43cc3e8) adds 673,737 OSM address rows and 370,149 Portuguese houses (2,514,810 to 2,884,959).
  • Noted that the panel score is now mostly self-agreement, since its cases are OSM address nodes and those nodes are indexed. Houses that passed before now answer the OSM node for the same house, 3 to 36 m from the register's point and under its full name.
  • Recorded the one panel group still failing: it writes a plot number (Lote 5 Bairro das Chancas).

Review focus

Check that the numbers and the #233/#240 description match what those PRs did. There is no code or chart change, so the gold run should show no change.

Refs #222

@github-actions

Copy link
Copy Markdown

Speed, full index: SuggestAddress slower, p50 +12% (limit +10%)

SearchAddress

Time in ms over 1995 cases, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 5129.5 1.8 4.7 14.8 22.0
head 5346.3 1.9 4.9 13.9 21.0
change +4% +6% +5% -6% -5%

SuggestAddress

Time in ms over 1996 checks, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 2115.4 0.9 1.7 3.4 12.8
head 2298.6 1.0 1.8 3.4 10.1
change +9% +12% +7% +1% -21%

ReverseGeocode

Time in ms over 1990 cases, each the fastest of 3 requests.

Total p50 p90 p99 Max
base 1538.9 0.7 1.0 3.3 6.7
head 1609.6 0.7 1.0 3.2 4.9
change +5% +4% +3% -1% -26%

Fails when the total, p50, p90 or p99 of any table is more than 10% slower. Runs of one binary differ by up to 5%; the max is one request and only reported.

Base 43cc3e8 → 345f198, one after the other in one pod on the same node and index.

@github-actions

Copy link
Copy Markdown

Gold check, full index: no regressions

RPC Checked Pass base Pass head Change Results changed
SearchAddress 21203 16999 16999 0 0
SuggestAddress 21287 15194 15194 0 0
ResolveRegion 3341 3322 3322 0 0
ReverseGeocode 20881 20755 20755 0 0
Runs
  • baseline: base, backend overture-index data index a24b013bba23, consumer binary e523e79c8190 models 2de098b5667f
  • candidate: head, backend overture-index data index 552d8f8d99ed, consumer binary e523e79c8190 models 2de098b5667f

Landmark checks (head)

Check Cohort pass ranked_low missing unexpected error
full suggest_landmark 53 0 18 0 0
off suggest_landmark 71 0 0 0 0
Check Cohort pass empty wrong_place wrong_region wrong_country
--- --- ---: ---: ---: ---: ---:

…dexed

#233 moved Portugal's extract to the address list and #240 made the build read it. Link that measurement from the Portugal triage and record what the panel's passing houses now answer. Refs #222.
@Mokto
Mokto force-pushed the fix/index-portugal-osm-addresses branch from 345f198 to 1b273b2 Compare October 20, 2026 15:40
@Mokto Mokto changed the title fix: index Portugal's OpenStreetMap addresses docs: record Portugal's source coverage now that its OSM addresses are indexed Oct 20, 2026
@Mokto
Mokto merged commit 84ee593 into main Oct 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant