Skip to content

docs: record Portugal's source coverage now that its OSM addresses are indexed #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mokto merged 1 commit into from
Oct 20, 2026
Merged

docs: record Portugal's source coverage now that its OSM addresses are indexed #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/evaluation/triage/portugal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ The panel writes every query in two synthetic orders ending in `, Portugal`. Por

On the full gold suite, SearchAddress is unchanged (its queries state the country) and SuggestAddress gains 34 checks with none lost: 31 Dutch queries written without commas (`Chopinstraat 51 5481LP Schijndel Netherlands`), two Spanish and one Italian with the number as its own part (`Via Bernardo Clesio, 5, 38122 Trento, Italy`).

Still open without a country: a query whose number the index lacks can get no answer at all when the postcode's place and the stated town differ in name (`Estrada de Mem Martins 9999, 2725-377 Mem Martins`; 3 of 39 such probes), because accepting the postcode for that town requires a stated country. That is a resolver rule for every country, left for a separate change.
Still open without a country: a query whose number the index lacks can get no answer at all when the postcode's place and the stated town differ in name (`Estrada de Mem Martins 9999, 2725-377 Mem Martins`; 3 of 39 such probes), because accepting the postcode for that town requires a stated country. That is a resolver rule for every country, tracked in [#234](https://github.com/Mokto/opengeocoding/issues/234).

## Source coverage

The 18 absent numbers are coverage, not handling. Portugal's addresses come only from the register; Portugal is among the `osmLandmarks` extracts, read for landmarks only, so OpenStreetMap's Portuguese addresses never reach the index. Adding `portugal` to the `osm` sources would fill some of these gaps, but this panel is drawn from the same OpenStreetMap address nodes, so its Portuguese score would then largely measure the source agreeing with itself: that would be a data change to judge on other evidence, separately from this code.
The 18 absent numbers were coverage, not handling: Portugal's addresses came only from the register, and its OpenStreetMap extract was read for landmarks only. [#233](https://github.com/Mokto/opengeocoding/pull/233) reads it for addresses too, and [#240](https://github.com/Mokto/opengeocoding/pull/240) makes the build take it from the snapshot's sealed landmark mirror (before #240, moving an extract between `osmLandmarks` and `osm` renamed the index without changing its content). Coverage and panel measurements are in [OSM addresses for Chile, Colombia, Mexico, Portugal and Taiwan](osm-address-countries.md): about 14% more Portuguese houses, and the panel's search at 105 of 106 Portuguese checks.

That panel score is now mostly self-agreement: its cases are OpenStreetMap address nodes, and those nodes are indexed. A world build with only Portugal's extract added (builder `9d4006a4eec15abb`, consumer `43cc3e8`) adds 673,737 OSM address rows and 370,149 Portuguese houses (2,514,810 → 2,884,959). The panel houses that already passed now answer the OSM node for the same house, 3–36 m from the register's point and under its full name (`Rua Tenente Valadim` for `R TEN VALADIM`). The one panel group still failing writes a plot number (`Lote 5 Bairro das Chancas`).