Skip to content

Fix ValueError from ULP-adjacent tied filtration values in computeReeb #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishikaghosh2201 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix ValueError from ULP-adjacent tied filtration values in computeReeb #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10b8235
Fix ValueError from ULP-adjacent tied filtration values in computeReeb
ishikaghosh2201 Sep 18, 2026
4e29ee7
Merge branch 'master' into fix-tied-vertices-valueerror
ishikaghosh2201 Sep 28, 2026
c9fe1dd
Update pulp version constraint in requirements.txt
ishikaghosh2201 Sep 28, 2026
c57255c
Update pulp dependency version constraint
ishikaghosh2201 Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cereeberus/cereeberus/compute/computereeb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

from ..reeb.lowerstar import LowerStar

# Tolerance for treating two filtration values as float64-indistinguishable
# (i.e. within ~1 ULP of each other, the scale of floating-point rounding
# noise. It is not intended to merge genuinely distinct nearby values).
_ULP_RTOL = 1e-9
_ULP_ATOL = 1e-12


class _DenseUnionFind:
"""Small array-backed union-find used by the exact slice sweep."""
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ dependencies = ["numpy",
"matplotlib",
"pandas",
"scipy",
"pulp",
"pulp<4",
"gudhi",
"scikit-learn"
]
Expand All @@ -34,4 +34,4 @@ cereeberus = ["data"]
[project.urls]
repository = "https://github.com/MunchLab/ceREEBerus"
homepage = "https://munchlab.github.io/ceREEBerus/"
documentation = "https://munchlab.github.io/ceREEBerus/"
documentation = "https://munchlab.github.io/ceREEBerus/"
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ networkx
matplotlib
pandas
scipy
pulp
pulp<4
gudhi
sphinx
nbsphinx
Expand Down
Loading