Smooth Catmull-Clark meshes at refinement zero - #11
Draft
nicolaspopravka wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Nicolas Popravka <nicolaspopravka@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
patch
Issues/Tickets:
N/A
Release notes comment:
Preserve smooth shading for Catmull-Clark meshes when Hydra refinement is set to zero.
Comments for the reviewer:
At refinement level zero, hdMoonRay disables subdivision and also disabled generated smooth normals. This caused Catmull-Clark meshes without authored normals to render with faceted shading.
This change keeps subdivision disabled at refinement zero but enables MoonRay's generated smooth normals when the mesh:
forcePolygonsetting.Meshes with subdivision scheme
none, explicitly flat-shaded meshes, and meshes rendered withforcePolygonremain flat.Validation performed:
The ALab comparison is available at:
https://github.com/nicolaspopravka/usd-render-benchmark/tree/test/cy2025-moonray-only
Look or scene setup change:
This intentionally changes Catmull-Clark meshes rendered at refinement zero from faceted to smooth shading when they do not provide explicit normals. RATS has not been run locally and will require upstream validation.
Special notes for production:
No effect is expected for refined subdivision meshes, subdivision scheme
none, explicitly flat-shaded representations, orforcePolygonrendering.Attention/Reviewers:
AI Assisted Development:
Assisted-by: OpenAI Codex / GPT-5
Codex was used to investigate the issue, implement portions of the change, and draft the initial description. I reviewed and tested the resulting changes and take responsibility for the contribution.
Checklist: