Skip to content

Smooth Catmull-Clark meshes at refinement zero #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicolaspopravka wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −5
Draft

Smooth Catmull-Clark meshes at refinement zero #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lib/hydramoonray/Mesh.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,11 @@ Mesh::syncSubdivScheme(const HdMeshTopology& topology,
// - the refine level is < 1
// - the "forcePolgon" render setting is on, or
// - the subd scheme is "none"
bool disableSubd = _GetReprDesc(reprToken)[0].flatShadingEnabled ||
bool flatShading = _GetReprDesc(reprToken)[0].flatShadingEnabled;
bool forcePolygon = renderDelegate.getForcePolygon();
bool disableSubd = flatShading ||
refineLevel < 1 ||
renderDelegate.getForcePolygon() ||
forcePolygon ||
subdScheme == PxOsdOpenSubdivTokens->none;


Expand All @@ -235,9 +237,16 @@ Mesh::syncSubdivScheme(const HdMeshTopology& topology,
}

if (not isPrimvarUsed(smoothNormalToken)) {
// polygons should not autogenerate smooth normals, per UsdGeomMesh doc
if (disableSubd)
geometry()->set(rdlAttrSmoothNormal, false);
if (disableSubd) {
// Preserve the smooth appearance of Catmull-Clark meshes when
// refinement is zero. Explicit flat shading, forcePolygon, and
// non-subdivision meshes remain flat.
bool smoothNormal = !flatShading &&
!forcePolygon &&
subdScheme != PxOsdOpenSubdivTokens->none &&
rdlScheme == rdlSubdSchemeCatClark;
geometry()->set(rdlAttrSmoothNormal, smoothNormal);
}
}
}

Expand Down