Repository navigation
Conversation
Releases are `## WinchControllers vX.Y.Z YYYY-MM-DD` with `###` groups, and the pending v0.6.5 note moves verbatim to changelog.d/. v0.5.2 gets its tag date, 2025-05-29. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same line as #38; left untracked it blocks the box's pre-push gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1-Bort-1
left a comment
There was a problem hiding this comment.
Independent review (advisory)
Verdict: APPROVE WITH COMMENTS · 0 inline, 0 off the diff
Good
- Only header lines changed in CHANGELOG.md: every removed
###/####line comes back as##/###with the same text, and the note bodies are untouched context lines. - The v0.5.2 date (2025-05-29) falls between v0.5.1 (05-28) and v0.5.3 (05-31), which fits the tag date the card cites.
- The pending v0.6.5 note was moved word for word into
changelog.d/winch-pos-anti-windup.md, so no## Unreleasedheader without a version is left for the box's first-##parser to trip on. - The PR stays inside the plan: the two old
### Removedgroups were moved to the new level, not renamed, andbin/releasewas left alone on purpose, with the reason given in the card. - The
.gitignoreline is named under 'Found on the way', gives its reason (the pre-push gate), and is identical to the one in #38, so the two merge cleanly in either order.
Not good
- After this merges, the repo's own
bin/releasegreps^###(lines 70-85) and will take### Addedas the top entry, so it is broken onmainuntil the release PR replaces it. The card says so, but nothing in the repo warns someone who runs it by hand. - The safety of the moved note depends on
agent releasefoldingchangelog.d/*.mdinto the v0.6.5 section. Nothing in this PR checks that the### Fixedheading inside the fragment is the format the box expects. - The fragment keeps the hard-wrapped lines of the old note, but rubric §6 says prose is one line per paragraph. Moving it verbatim is defensible, but a fresh file was the cheap moment to unwrap it.
.gitignoreis outside the changelog idea and is not 'around the change' in the §1 sense. It is small and explained, but it is still a second idea riding along.
claude, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.
bin/release grepped for '### ' entries, which after the header move would pick up '### Added'. The pending note is now one line per paragraph, text unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Local full suite: PASS (2 min, Julia 1.13.0, one cell of the matrix) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
From Per 1-Bart-1/Agents#635: since 1-Bart-1/Agents#634 the release bump writes headers as |
Release headers follow the box's ## <Package> vX.Y.Z DD-MM-YYYY form; bin/release converts the header date back to ISO for CITATION.cff. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## WinchControllers vX.Y.Z YYYY-MM-DD headers, pending notes in changelog.d/## WinchControllers vX.Y.Z DD-MM-YYYY headers, pending notes in changelog.d/
|
From Per 1-Bart-1/Agents#635 (comment 6099024080) ISO is the convention after all: the bump goes back to writing |
The release bump writes ## <Package> vX.Y.Z YYYY-MM-DD again (1-Bart-1/Agents#635), so the headers and bin/release's date read go back to ISO. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## WinchControllers vX.Y.Z DD-MM-YYYY headers, pending notes in changelog.d/## WinchControllers vX.Y.Z YYYY-MM-DD release headers, pending notes in changelog.d/
We want one changelog format across the OpenSourceAWE packages, so the release tooling can read every one of them the same way. This gives WinchControllers the same release and section headers as the others: each release is a second-level heading naming the package, the version and an ISO date, with Added/Changed/Fixed/Removed one level below it. Only header lines change; every note reads as before.
The one note not yet released, a fix to the speed controller's anti-windup, moves out of the changelog into its own file in
changelog.d/, where the next release picks it up. That keeps the top release header equal to the version inProject.toml. Version 0.5.2 had no date; it now carries 2025-05-29, the day its tag was made.The repo's own release script read release headers one level too deep and would have refused every release after this change; it now reads the new level.
.gitignorealso gains the machine-localLocalPreferences.toml, the same line #38 adds, so the two merge in either order.Verification
--dry-run --sha origin/main, givesVersion mismatch: Project.toml is 0.6.4 but CHANGELOG top is (expected v0.6.4)., exit 1--dry-run --shaon this branch's head (541e769), printsVersion: v0.6.4and the 0.6.4 notes (Added/Changed), exit 0## WinchControllers v0.6.5 <date>/### Fixed, above v0.6.4bin/releaseheader parse: the copy on main against this CHANGELOG stops attop entry ('### Added') does not match, exit 1; this branch's copy reads## WinchControllers v0.6.4 2026-09-28and its notes, exit 0, and still rejects 0.6.3. Its date read gives2026-09-28fordate-releasedinCITATION.cff. The full script was not run, since it pushes and posts.Opened by
1-Bort-1, an AI agent working for @1-Bart-1.Closes #39 · task
WinchControllers.jl-39