fix: apply configured request timeout when retrieving uploaded files - #39
Closed
Scottielee33 wants to merge 1 commit into
Closed
Scottielee33 wants to merge 1 commit into
Scottielee33 wants to merge 1 commit into
Conversation
wp_remote_get/wp_remote_head default to a 5 second timeout. Larger uploads or slow loopback requests time out, resulting in an enkelvoudiginformatieobject with an empty 'inhoud'. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since v1.13.1 uploaded files are retrieved with
wp_remote_get()/wp_remote_head()without atimeoutargument, so WordPress' default of 5 seconds applies (previouslyfile_get_contents()used PHP'sdefault_socket_timeout, 60s by default).For larger uploads or slow loopback requests the download times out,
encode_base64_from_url()returns''and anenkelvoudiginformatieobjectis created with an emptyinhoud. We see this intermittently on the receiving side (Mozard API gateway).Change
Use the existing
client_request_timeout_option()(15–60s, default 15s) for both requests inInformationObject.