🔒 ci: clear SonarCloud S8545 and S6506 findings - #146
Merged
Merged
Conversation
go install already resolves a pinned version through the module checksum database; -mod=readonly additionally forbids the build from rewriting the target module go.mod/go.sum, so the install is lock-file enforcing. Clears SonarCloud githubactions:S8545.
curl --proto '=https' --tlsv1.2 also applies to redirects, so a release asset redirect can no longer downgrade. Clears SonarCloud shell:S6506.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two behaviour-preserving hardening fixes from the security sweep.
.github/workflows/verify.yaml: the three pinnedgo install <tool>@<version>steps (Task twice, golangci-lint once) now pass-mod=readonly, so the install cannot rewrite the target module's go.mod/go.sum. Same pinned versions, same binaries (githubactions:S8545).hack/install-git-cliff.sh: the release download usescurl --proto '=https' --tlsv1.2, which also holds across redirects (shell:S6506).Not changed: go:S4036 in
internal/schemadrift/drift.go(exec.Command("git", ...)by bare name). Resolving it means changing how git is located, which is a design choice left to the maintainer.Local checks: actionlint, shellcheck, hack/lint/workflow_pins_test.sh, install script run against v2.13.1.