Skip to content

🔒 ci: clear SonarCloud S8545 and S6506 findings #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konih merged 2 commits into from
Sep 21, 2026
Merged

🔒 ci: clear SonarCloud S8545 and S6506 findings #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e56bd88
:lock: ci(verify): install pinned Task and golangci-lint with -mod=re…
konih Sep 21, 2026
bf739d4
:lock: build(release): restrict git-cliff download to HTTPS and TLS 1.2+
konih Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:
go test -count=2 ./internal/forge/... -run TestMergeFailsClosedDoubleRun
go test -count=2 ./internal/render/... -run 'TestRenderGoldens|TestRenderSummaryGolden'
- name: install Task (coverage + exit gate scripts)
run: go install github.com/go-task/task/v3/cmd/task@"${TASK_VERSION}"
run: go install -mod=readonly github.com/go-task/task/v3/cmd/task@"${TASK_VERSION}"
# AUD-S13 / D-128 — the coverage floor is SINGLE-SOURCED in Taskfile.yml's
# `coverage:` task (var COVERAGE_MIN). This step used to re-implement the gate
# inline with its own copy of the threshold, so raising the local floor left CI
Expand Down Expand Up @@ -240,13 +240,13 @@ jobs:
with:
enable-cache: true
- name: install Task
run: go install github.com/go-task/task/v3/cmd/task@"${TASK_VERSION}"
run: go install -mod=readonly github.com/go-task/task/v3/cmd/task@"${TASK_VERSION}"
# AUD-S18: `task check` runs `task lint` and `lint-depguard-test`, both of
# which need the golangci-lint BINARY on PATH. The verify job lints via the
# action, which leaves nothing behind for a later step (D-125), so the exit
# gate needs its own pinned install. Version single-sourced at workflow level.
- name: install golangci-lint (AUD-S18 — task check needs it on PATH)
run: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@"${GOLANGCI_LINT_VERSION}"
run: go install -mod=readonly github.com/golangci/golangci-lint/v2/cmd/golangci-lint@"${GOLANGCI_LINT_VERSION}"
- name: E9 release exit gate (RELSE-03 — REQ-E9-S13)
run: bash hack/release/exitgate_test.sh
# AUD-S18 (REQ-AUD-S18-01/02) — the P5-AUD exit gate: the 2026-08-06 audit's
Expand Down
2 changes: 1 addition & 1 deletion hack/install-git-cliff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ mkdir -p "$(dirname "${root}/${OUT}")"
tmpdir="$(mktemp -d)"
trap 'rm -rf "${tmpdir}"' EXIT

curl -fsSL "${url}" -o "${tmpdir}/git-cliff.tgz"
curl --proto '=https' --tlsv1.2 -fsSL "${url}" -o "${tmpdir}/git-cliff.tgz"
tar -xzf "${tmpdir}/git-cliff.tgz" -C "${tmpdir}"
install -m 0755 "${tmpdir}/git-cliff-${VER}/git-cliff" "${root}/${OUT}"
echo "installed ${OUT} (${VERSION} ${platform})"
Loading