FIX: update GitHub pull requests doc link to final destination - #590
Merged
Conversation
The GitHub docs URL for "About pull requests" now 301-redirects to https://docs.github.com/en/pull-requests/reference/pull-requests Point directly at the destination so the weekly link checker stops flagging it as a redirect. Reported by the link checker in #587 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a GitHub documentation link in the “workspace” lecture to avoid an unnecessary redirect, keeping the lecture’s external references current and stable.
Changes:
- Replace the “About pull requests” GitHub Docs URL with its current canonical destination (
/pull-requests/reference/pull-requests).
Contributor
Author
✅ Translation sync completed (zh-cn)Target repo: QuantEcon/lecture-python-programming.zh-cn
|
Contributor
Author
✅ Translation sync completed (fr)Target repo: QuantEcon/lecture-python-programming.fr
|
Contributor
Author
✅ Translation sync completed (fa)Target repo: QuantEcon/lecture-python-programming.fa
|
mmcky
added a commit
that referenced
this pull request
Aug 3, 2026
The GitHub docs URL for "About pull requests" now 301-redirects to https://docs.github.com/en/pull-requests/reference/pull-requests Point directly at the destination so the weekly link checker stops flagging it as a redirect. Reported by the link checker in #587 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one genuine finding in #587.
The GitHub docs URL for "About pull requests" in
lectures/workspace.mdnow 301-redirects, so this points it directly at the destination:https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requestshttps://docs.github.com/en/pull-requests/reference/pull-requestsThis matches the AI suggestion in the report, and I verified the redirect chain resolves
301to that exact target with a200.About the other two findings in #587
The two FRED links reported as broken are false positives and need no change here. Both return
200in well under a second from a normal network; the0 (Timeout)status is FRED throttling GitHub Actions runner IPs. They are already whitelisted for Sphinx inlectures/_config.ymlunderlinkcheck_ignore, but the link checker scans built HTML and never sees that configuration.That is the root cause of the eight older duplicate issues (#555, #556, #559, #564, #565, #567, #571, #583), which I am closing in favour of #587. The fix belongs in the action rather than in this repo, and is tracked upstream in QuantEcon/action-link-checker#2, which requests an
ignore-patternsinput plus issue deduplication.Heads-up for the next release
The report only flags
pandas.html, butlectures/polars.mdcarries the identical FRED link. The checker runs against the latest release tarball, which predates the Polars lecture, so expect these to double to four false positives after the next release until the upstream ignore list lands.🤖 Generated with Claude Code