Skip to content

Replace the AI Mode document tabs with detail blocks and header publish controls - #1118

Merged
yattias merged 1 commit into
mainfrom
ai-mode-workspace/detail-blocks
Oct 8, 2026
Merged

yattias merged 1 commit into
mainfrom
ai-mode-workspace/detail-blocks

Conversation

@yattias

@yattias yattias commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

The document pane's Document / Publish tabs become a strip of detail
blocks — Applying to, Funding goal, Authors, Cover image for a proposal;
Funding amount, Short description, Contacts, Cover image for an RFP —
each opening a popover with just its section of the form (or, for the
RFP picker, the existing modal). The strip shows as many blocks as the
pane is wide enough for, in a fixed order, and folds the rest into the
"All details" block, which opens the full form and says how many it
holds (hooks/useFittingCount). The workspace header gains the document's
title, a "N remaining" pill and a Publish button that stays disabled
until nothing required is missing; a published document shows a
Published pill and an Update button. The form now lives as long as the
note does, so switching views no longer rehydrates it from stale content.

Below the tablet breakpoint the drawer trades the strip for a
Document | Details switch, with the remaining count on Details and the
publish controls inline.

Supporting changes: completion.ts derives what is missing from the zod
schema without touching form errors; PublishStatusPill; PublishButton
gains requireComplete and reads Update for published works; the funding
section is split into FundingOpportunityField, FundingGoalField and a
FundingGoalSection with a shared useSelectedGrant; sections take a
className so they render bare in a popover; PublishingForm gains
showFooter; NotebookTabs loses its labels prop and the header its
"Esc to close" hint.

Verified with type-check, eslint and prettier only.

Stack

Part of turning the AI Mode overlay into a funding workspace (plan and mock decisions in the first PR's thread). Stacked on #1116; merge that first, then this one.

  1. Wrapping AIMode and notebook with publishing provider #1116
  2. Replace the AI Mode document tabs with detail blocks and header publish controls #1118
  3. Share one chat session between the AI Mode overlay and the notebook panel #1117
  4. Start a workspace conversation by saying whether you fund or need funding #1119
  5. Lift the notebook's note listing into a hook and name a note's kind #1120
  6. Break the AI Mode overlay into a shell, a sidebar and the panes #1121
  7. Open documents in the workspace, with a chat on each that is kept once used #1122
  8. Give phones a full-screen view of conversations and documents #1123
  9. Workspace review fixes: one-line sidebar rows, no layout toggle, no notebook link #1124

🤖 Generated with Claude Code

@yattias
yattias requested a review from a team as a code owner September 22, 2026 09:07
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
web Ready Ready Preview Oct 8, 2026 2:47pm UTC

Request Review

…sh controls

The document pane's Document / Publish tabs become a strip of detail
blocks — Applying to, Funding goal, Authors, Cover image for a proposal;
Funding amount, Short description, Contacts, Cover image for an RFP —
each opening a popover with just its section of the form (or, for the
RFP picker, the existing modal). The strip shows as many blocks as the
pane is wide enough for, in a fixed order, and folds the rest into the
"All details" block, which opens the full form and says how many it
holds (hooks/useFittingCount). The workspace header gains the document's
title, a "N remaining" pill and a Publish button that stays disabled
until nothing required is missing; a published document shows a
Published pill and an Update button. The form now lives as long as the
note does, so switching views no longer rehydrates it from stale content.

Below the tablet breakpoint the drawer trades the strip for a
Document | Details switch, with the remaining count on Details and the
publish controls inline.

Supporting changes: completion.ts derives what is missing from the zod
schema without touching form errors; PublishStatusPill; PublishButton
gains requireComplete and reads Update for published works; the funding
section is split into FundingOpportunityField, FundingGoalField and a
FundingGoalSection with a shared useSelectedGrant; sections take a
className so they render bare in a popover; PublishingForm gains
showFooter; NotebookTabs loses its labels prop and the header its
"Esc to close" hint.

Verified with type-check, eslint and prettier only.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@yattias
yattias force-pushed the ai-mode-workspace/publishing-core branch from 95e18fa to c7a6cb5 Compare October 8, 2026 14:46
@yattias
yattias force-pushed the ai-mode-workspace/detail-blocks branch from fcbb843 to ddac2b8 Compare October 8, 2026 14:46
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@yattias
yattias removed this pull request from stack #1146 October 8, 2026 15:07
Base automatically changed from ai-mode-workspace/publishing-core to main October 8, 2026 15:29
@yattias
yattias merged commit ddac2b8 into main Oct 8, 2026
2 of 4 checks passed
@yattias
yattias deleted the ai-mode-workspace/detail-blocks branch October 8, 2026 15:29

This branch was successfully deployed

1 active deployment
Preview — ddac2b8b Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant