Skip to content

[Chore] Remove order-dependent runtime listener test - #1579

Draft
roomote-roomote[bot] wants to merge 1 commit into
developfrom
chore/remove-low-value-test-23gzptwy3avgr
Draft

[Chore] Remove order-dependent runtime listener test#1579
roomote-roomote[bot] wants to merge 1 commit into
developfrom
chore/remove-low-value-test-23gzptwy3avgr

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the task or mention @roomote-roomote for follow-up asks.

​Created by Roomote. Follow up by mentioning @roomote-roomote or in the web UI.

What changed

Removed the test that only checked global process signal-listener counts after a separate test leased a server.

Why this change was made

The assertion depended on test order and verified a private implementation detail rather than shutdown behavior. The retained process-tree shutdown test exercises the observable cleanup regression directly.

Impact

No production behavior or public contract changes. The test suite has one fewer order-dependent, maintenance-heavy case while preserving meaningful OpenCode server shutdown coverage.

Validation

  • opencode-runtime.test.ts: 26 passed.
  • Fast-agent bridge and service overlap tests: 40 passed.
  • @roomote/cloud-agents typecheck passed.
  • Package formatting and targeted oxlint passed.
  • Pre-push checks passed: oxlint, residual lint, fast typecheck, and knip.

@roomote-community

roomote-community Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 2e6a4cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant