[Chore] Remove order-dependent runtime listener test - #1579
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Chore] Remove order-dependent runtime listener test#1579roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed the test that only checked global
processsignal-listener counts after a separate test leased a server.Why this change was made
The assertion depended on test order and verified a private implementation detail rather than shutdown behavior. The retained process-tree shutdown test exercises the observable cleanup regression directly.
Impact
No production behavior or public contract changes. The test suite has one fewer order-dependent, maintenance-heavy case while preserving meaningful OpenCode server shutdown coverage.
Validation
opencode-runtime.test.ts: 26 passed.@roomote/cloud-agentstypecheck passed.