Repository navigation
Blank Quartz's placeholder H2 admin/admin datasource credential - #3207
Open
terryozaki-wq wants to merge 1 commit into
Open
terryozaki-wq wants to merge 1 commit into
terryozaki-wq wants to merge 1 commit into
Conversation
…redential quartz.properties shipped with a real-looking hardcoded H2 datasource credential (user=admin, password=admin, URL pointing at a developer's own Windows machine path), despite SchedulerFactorySingleton.init() always routing through setUpQuartzProperties(), which unconditionally overwrites driver/URL/user/password with the actual scheduler database's own connection details before Quartz's StdSchedulerFactory is ever initialized - confirmed by direct trace of both call sites in init() (the IEmbeddedRDBMSServerEngine and RDBMSNativeEngine branches) and the single setUpQuartzProperties() implementation they share. This fails open rather than closed: Quartz would simply run with the weak default silently if the override logic were ever changed to skip it, since there's no equivalent of a fail-closed ConfigurationException. Blanking the four placeholder values instead means a future regression in the override logic would surface as an obvious connection failure. Added SchedulerFactorySingletonUnitTests to confirm, using the real project quartz.properties copied into the test's base folder exactly as semosshome.xml packages it for deployment: the four placeholders are blank (not "admin") in the file itself, setUpQuartzProperties() correctly overwrites all four with real connection details regardless, and the non-connection settings (jobStore.class, tablePrefix) still load from the file as before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quartz.propertiesshipped with a real-looking hardcoded H2 datasource credential (user=admin,password=admin, URL pointing at a developer's own Windows machine path), despiteSchedulerFactorySingleton.init()always routing throughsetUpQuartzProperties(), which unconditionally overwrites driver/URL/user/password with the actual scheduler database's own connection details before Quartz'sStdSchedulerFactoryis ever initialized — confirmed by direct trace of both call sites ininit()and the singlesetUpQuartzProperties()implementation they share.Test plan
SchedulerFactorySingletonUnitTests, using the real projectquartz.propertiescopied into the test's base folder exactly assemosshome.xmlpackages it for deployment: confirms the four placeholders are blank (notadmin) in the file itself,setUpQuartzProperties()correctly overwrites all four with real connection details regardless, and non-connection settings (jobStore.class,tablePrefix) still load from the file as before — 3/3 passing.🤖 Generated with Claude Code