Blank Quartz's placeholder H2 admin/admin datasource credential

quartz.properties

@@ -22,12 +22,18 @@ org.quartz.jobStore.dataSource=myDS
 org.quartz.jobStore.useProperties=false
 org.quartz.jobStore.isClustered=false
 
-# persist to H2 database at path '/tmp/MyScheduler.quartz.h2'
-org.quartz.dataSource.myDS.driver = org.h2.Driver
-
-#Quartz dataSource
-org.quartz.dataSource.myDS.URL=jdbc:h2:tcp://localhost:9092/C:/workspace/Semoss_Dev/quartz/db3
-org.quartz.dataSource.myDS.user=admin
-org.quartz.dataSource.myDS.password=admin
+# driver/URL/user/password below are template-only placeholders: every actual
+# Quartz initialization goes through SchedulerFactorySingleton.setUpQuartzProperties(),
+# which loads this file then unconditionally overwrites all four with the real
+# scheduler database's own driver/connection URL/credentials before the factory
+# is ever initialized. Left as a real-looking admin/admin H2-on-localhost value,
+# this reads as a live hardcoded credential to any secret scanner even though it
+# is never actually used; left blank instead, a future change that accidentally
+# stops overriding these would fail obviously (Quartz cannot connect) rather than
+# silently running with a weak default.
+org.quartz.dataSource.myDS.driver=
+org.quartz.dataSource.myDS.URL=
+org.quartz.dataSource.myDS.user=
+org.quartz.dataSource.myDS.password=
 org.quartz.dataSource.myDS.maxConnections=5
 org.quartz.dataSource.myDS.validationQuery=select 1

test/prerna/reactor/scheduler/SchedulerFactorySingletonUnitTests.java

@@ -0,0 +1,98 @@
+/*******************************************************************************
+ * Copyright 2015 Defense Health Agency (DHA)
+ *
+ * If your use of this software does not include any GPLv2 components:
+ * 	Licensed under the Apache License, Version 2.0 (the "License");
+ * 	you may not use this file except in compliance with the License.
+ * 	You may obtain a copy of the License at
+ *
+ * 	  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * 	Unless required by applicable law or agreed to in writing, software
+ * 	distributed under the License is distributed on an "AS IS" BASIS,
+ * 	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * 	See the License for the specific language governing permissions and
+ * 	limitations under the License.
+ * ----------------------------------------------------------------------------
+ * If your use of this software includes any GPLv2 components:
+ * 	This program is free software; you can redistribute it and/or
+ * 	modify it under the terms of the GNU General Public License
+ * 	as published by the Free Software Foundation; either version 2
+ * 	of the License, or (at your option) any later version.
+ *
+ * 	This program is distributed in the hope that it will be useful,
+ * 	but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * 	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * 	GNU General Public License for more details.
+ *******************************************************************************/
+package prerna.reactor.scheduler;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import java.util.Properties;
+
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+import prerna.SemossUnitTest;
+import prerna.util.sql.RdbmsTypeEnum;
+
+/**
+ * quartz.properties ships with blank driver/URL/user/password placeholders
+ * (see the comment above them in that file) since SchedulerFactorySingleton
+ * always overwrites those four with the real scheduler database's own
+ * connection details before Quartz is initialized. This confirms that
+ * override actually happens, using the real project quartz.properties copied
+ * into the test's base folder exactly as the deployed semosshome packaging
+ * does (per semosshome.xml).
+ */
+class SchedulerFactorySingletonUnitTests extends SemossUnitTest {
+
+	@BeforeAll
+	static void copyQuartzProperties() throws IOException {
+		Path projectRoot = Paths.get("").toAbsolutePath();
+		Path source = projectRoot.resolve("quartz.properties");
+		Files.copy(source, semossDir.resolve("quartz.properties"), StandardCopyOption.REPLACE_EXISTING);
+	}
+
+	@Test
+	void realConnectionDetailsOverwriteThePlaceholders() {
+		Properties result = SchedulerFactorySingleton.setUpQuartzProperties(null, "jdbc:h2:mem:realtest", "realuser",
+				"realpass", RdbmsTypeEnum.H2_DB);
+
+		assertEquals("jdbc:h2:mem:realtest", result.getProperty("org.quartz.dataSource.myDS.URL"));
+		assertEquals("org.h2.Driver", result.getProperty("org.quartz.dataSource.myDS.driver"));
+		assertEquals("realuser", result.getProperty("org.quartz.dataSource.myDS.user"));
+		assertEquals("realpass", result.getProperty("org.quartz.dataSource.myDS.password"));
+		assertEquals("org.quartz.impl.jdbcjobstore.StdJDBCDelegate",
+				result.getProperty("org.quartz.jobStore.driverDelegateClass"));
+	}
+
+	@Test
+	void placeholdersInTheFileItselfAreBlankNotARealCredential() throws IOException {
+		Properties raw = new Properties();
+		try (var in = Files.newInputStream(semossDir.resolve("quartz.properties"))) {
+			raw.load(in);
+		}
+
+		assertTrue(raw.getProperty("org.quartz.dataSource.myDS.user", "").isEmpty());
+		assertTrue(raw.getProperty("org.quartz.dataSource.myDS.password", "").isEmpty());
+		assertFalse(raw.getProperty("org.quartz.dataSource.myDS.password", "").equals("admin"));
+	}
+
+	@Test
+	void nonConnectionSettingsStillLoadFromTheFile() {
+		Properties result = SchedulerFactorySingleton.setUpQuartzProperties(null, "jdbc:h2:mem:realtest", "realuser",
+				"realpass", RdbmsTypeEnum.H2_DB);
+
+		assertEquals("org.quartz.impl.jdbcjobstore.JobStoreTX", result.getProperty("org.quartz.jobStore.class"));
+		assertEquals("QRTZ_", result.getProperty("org.quartz.jobStore.tablePrefix"));
+	}
+}