Skip to content

fix(daemon): log repeated admission timeouts at debug, first at info - #297

Merged
OnFreund merged 1 commit into
Sendspin:mainfrom
kiwipaulrob:fix/admission-timeout-log-once
Oct 17, 2026
Merged

OnFreund merged 1 commit into
Sendspin:mainfrom
kiwipaulrob:fix/admission-timeout-log-once

Conversation

@kiwipaulrob

Copy link
Copy Markdown
Contributor

What does this implement/fix?

When a server keeps redialing, every unadmitted connection logs the same info line, so the daemon log fills with repeats of one event:

INFO:sendspin.daemon.daemon:Incoming connection did not complete admission (handshake timed out or was aborted); waiting for a retry.

I hit this watching my own player logs, where the line repeats on every reconnect and buries everything else. This keeps the first occurrence at info (an unadmitted connection would otherwise be fully silent, as the code comment notes) and moves repeats to debug. The flag resets once a connection is admitted, so a later wedged spell is visible again at info.

No behavior change apart from log level: three lines of state (one bool, set on first log, cleared on admission).

Related issue (if applicable):

  • none filed — happy to open one if you would rather track it that way.

Types of changes

  • Bugfix (non-breaking change which fixes an issue): bugfix
  • New feature (non-breaking change which adds functionality): new-feature
  • Enhancement to an existing feature: enhancement
  • Breaking change (changes CLI options, settings, hooks or the protocol in a way that is not backwards compatible): breaking-change
  • Refactor (no behavior change): refactor
  • Documentation only: documentation
  • Maintenance / chore: maintenance
  • CI / workflow change: ci
  • Dependencies bump: dependencies

@github-actions github-actions Bot added the bugfix Fixes a bug label Oct 17, 2026
@kiwipaulrob
kiwipaulrob marked this pull request as ready for review October 17, 2026 06:49
@OnFreund
OnFreund merged commit c5e9eb8 into Sendspin:main Oct 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants