Skip to content

fix(daemon): log repeated admission timeouts at debug, first at info #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OnFreund merged 1 commit into from
Oct 17, 2026
Merged

fix(daemon): log repeated admission timeouts at debug, first at info #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions sendspin/daemon/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def __init__(self, args: DaemonArgs) -> None:
self._static_delay_ms: float = 0.0
self._connection_lock: asyncio.Lock | None = None
self._server_url: str | None = None
self._admission_timeout_logged: bool = False
self._group_update_unsubscribe: Callable[[], None] | None = None
self._server_command_unsubscribe: Callable[[], None] | None = None
self._pairing_abort_unsubscribe: Callable[[], None] | None = None
Expand Down Expand Up @@ -356,12 +357,27 @@ async def _handle_server_connection(self, ws: web.WebSocketResponse) -> None:
if exc is not None:
logger.warning("Handshake with server failed: %s", exc)
else:
logger.info(
"Incoming connection did not complete admission "
"(handshake timed out or was aborted); waiting for a retry."
)
# Admission timeouts recur on every reconnect while a server
# keeps redialing, so log the first at info (an unadmitted
# connection would otherwise be fully silent) and repeats at
# debug. The flag resets below once a connection is admitted.
if not self._admission_timeout_logged:
logger.info(
"Incoming connection did not complete admission "
"(handshake timed out or was aborted); waiting for a retry."
)
self._admission_timeout_logged = True
else:
logger.debug(
"Incoming connection did not complete admission "
"(handshake timed out or was aborted); waiting for a retry."
)
return

# Reaching here means the connection was admitted: re-arm the
# first-time info log so a later wedged spell is visible again.
self._admission_timeout_logged = False

# Lock ensures we wait for any in-progress handshake to complete
# before disconnecting the previous server
async with self._connection_lock:
Expand Down
Loading