Repository navigation
r202639: draw the reported position range - #23
Merged
Merged
Conversation
A panel that does not know its size reports 0, which the card took as the size and then refused to load. A size of 0, below zero, fractional or not a number is now treated as absent, and the size comes from the circuits. Part of the spanos3/r202639/03 batch 2 work.
Topology may report the panel's first and last breaker positions. The grid draws rows over that range, labelled with the positions' own numbers, instead of 1 to the panel size, so a breaker above the size is drawn and no empty slot appears below the first position. A panel that reports size 0 with its positions loads. Without reported positions the range is 1 to the size, as before, and it always widens to every occupied tab. Part of the spanos3/r202639/03 batch 2 work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r202639: the grid draws the breaker positions the panel reports.
panel_sizeattribute the same way.first_positionandlast_position. The grid draws one row per two positions over that range, labelled with the positions' own numbers. A range starting at 9 draws no slots 1 to 8, and a breaker above the panel size is drawn when the range reaches it. A panel that reports size 0 with its positions loads.buildGridHTMLtakes aPositionRangein place of a row count. A 1 to 32 range renders byte-identical to a 32-space panel that reports no range.The size check is its own first commit.
dist/is not rebuilt here; the release rebuilds it.Checks
npm test: 592 passed in 57 files (561 in 56 before)npm run typecheck,npm run lint,node scripts/validate-i18n.mjs: cleannpm run build: clean