Skip to content

Fix sumset docstring - #15038

Merged
cclauss merged 3 commits into
TheAlgorithms:masterfrom
sanchiagarwal0:fix-sumset-docstring
Sep 8, 2026
Merged

Fix sumset docstring#15038
cclauss merged 3 commits into
TheAlgorithms:masterfrom
sanchiagarwal0:fix-sumset-docstring

Conversation

@sanchiagarwal0

@sanchiagarwal0 sanchiagarwal0 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Describe your change:

Fixes #15013

Corrected the sumset() docstring:

  • Fixed the parameter names to set_a and set_b.
  • Corrected the return-value description.
  • Removed the incorrect reference to Sylvester's sequence.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests that will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • If this pull request resolves one or more open issues then the description above includes the issue number with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 16, 2026
@priya-sundaram-dev

Copy link
Copy Markdown
Contributor

Thanks — this fixes the sumset docstring AND adds a nice sumset(set(), {1,2,3}) empty-set doctest. Two issues: (1) it duplicates #15039/#15014, and (2) it's currently in merge conflict. Suggest we keep #15039 as the base and fold your empty-set doctest into it; otherwise please rebase. Your extra doctest is the most valuable part here.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 8, 2026
@cclauss
cclauss merged commit 96c429d into TheAlgorithms:master Sep 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files git merge conflict

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: maths/sumset.py docstring incorrectly references Sylvester's sequence

3 participants