fix: correct sumset() docstring - #15039
Closed
deepshekhardas wants to merge 2 commits into
Closed
Conversation
deepshekhardas
force-pushed
the
fix-15013-sumset-docstring
branch
from
August 21, 2026 05:18
151c90a to
6b23f9b
Compare
This was referenced Aug 21, 2026
This was referenced Aug 31, 2026
Contributor
|
Good catch — the old docstring wrongly described Sylvester's sequence. This fix is clean and mergeable. Note there are two sibling PRs fixing the same docstring: #15014 is byte-identical to this one, and #15038 adds an extra empty-set doctest but is currently conflicting. Recommending this one as the keeper; the other two can be closed once this lands (worth cherry-picking #15038's |
This was referenced Sep 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
What does this implement/fix?
The docstring of
sumset()inmaths/sumset.pywas a copy-paste fromsylvester_sequence.py. Correct the param names and return description to describe the sumset (all pairwise sums a + b).Additional comments?
None.
Fixes #15013