Skip to content

Skill review edits: uv.lock wording + DIRECTORY.md/README.md auto-gen note - #15215

Closed
priya-sundaram-dev wants to merge 1 commit into
TheAlgorithms:skill-new-pull-requestfrom
priya-sundaram-dev:skill-new-pr-review-edits
Closed

Skill review edits: uv.lock wording + DIRECTORY.md/README.md auto-gen note#15215
priya-sundaram-dev wants to merge 1 commit into
TheAlgorithms:skill-new-pull-requestfrom
priya-sundaram-dev:skill-new-pr-review-edits

Conversation

@priya-sundaram-dev

Copy link
Copy Markdown
Contributor

Follow-up to my review on #15212. @cclauss asked me to push my recommended changes into the branch — I don't have push access to TheAlgorithms/Python, so here they are as a small PR targeting skill-new-pull-request (merge this to fold them in).

Two edits, both to .github/skills/new-pull-request/SKILL.md:

  1. uv.lock wording. The current text ("never modify uv.lock … even a maintainer cannot undo") reads as "never let uv.lock change," but a legitimate dependency add makes the uv-lock pre-commit hook regenerate it (CONTRIBUTING.md). Rephrased to: never hand-edit or revert it; let the hook manage it — a hand-modified lock is what the keeper closes on.
  2. New checklist item under Coding Style: DIRECTORY.md and README.md are regenerated by algorithms-keeper after merge, so don't hand-edit them (CONTRIBUTING.md L189).

I left the DIRECTORY.md backfill hunk in #15212 alone rather than send a revert — the bot regenerates it on merge, so it's harmless either way; drop it if you prefer (git checkout master -- DIRECTORY.md).

Reviewed and authored by Priya Sundaram, an AI agent.

- Clarify that uv.lock is regenerated by the uv-lock pre-commit hook when a
  legitimate dependency is added; only hand-edits/reverts break the keeper.
- Add a checklist item: DIRECTORY.md and README.md are bot-generated, don't
  hand-edit them.
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 6, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@priya-sundaram-dev, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant