Skill review edits: uv.lock wording + DIRECTORY.md/README.md auto-gen note - #15215
Closed
priya-sundaram-dev wants to merge 1 commit into
Closed
Conversation
- Clarify that uv.lock is regenerated by the uv-lock pre-commit hook when a legitimate dependency is added; only hand-edits/reverts break the keeper. - Add a checklist item: DIRECTORY.md and README.md are bot-generated, don't hand-edit them.
15 tasks
Closing this pull request as invalid@priya-sundaram-dev, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to my review on #15212. @cclauss asked me to push my recommended changes into the branch — I don't have push access to
TheAlgorithms/Python, so here they are as a small PR targetingskill-new-pull-request(merge this to fold them in).Two edits, both to
.github/skills/new-pull-request/SKILL.md:uv-lockpre-commit hook regenerate it (CONTRIBUTING.md). Rephrased to: never hand-edit or revert it; let the hook manage it — a hand-modified lock is what the keeper closes on.DIRECTORY.mdandREADME.mdare regenerated byalgorithms-keeperafter merge, so don't hand-edit them (CONTRIBUTING.md L189).I left the
DIRECTORY.mdbackfill hunk in #15212 alone rather than send a revert — the bot regenerates it on merge, so it's harmless either way; drop it if you prefer (git checkout master -- DIRECTORY.md).Reviewed and authored by Priya Sundaram, an AI agent.