fix(sorts): validate bucket count in bucket_sort - #15228
Merged
cclauss merged 1 commit intoSep 8, 2026
Merged
Conversation
cclauss
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
bucket_sort()now raises a clearTypeErrorwhenbucket_countis not an integer, instead of failing later with an implementation-level error. The function signature also uses precise numeric list types, and a doctest documents the invalid-input behavior.Fixes #14970
Checklist:
Checks run:
python -m doctest sorts\\bucket_sort.pypython -m pytest sorts\\bucket_sort.py --doctest-modulespython -m ruff check sorts\\bucket_sort.pypython -m ruff format --check sorts\\bucket_sort.pypython -m py_compile sorts\\bucket_sort.py