Skip to content

fix(sorts): validate bucket count in bucket_sort #15228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 1 commit into from
Sep 8, 2026
Merged

fix(sorts): validate bucket count in bucket_sort #15228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sorts/bucket_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
from __future__ import annotations


def bucket_sort(my_list: list, bucket_count: int = 10) -> list:
def bucket_sort(
my_list: list[int | float], bucket_count: int = 10
) -> list[int | float]:
"""
>>> data = [-1, 2, -5, 0]
>>> bucket_sort(data) == sorted(data)
Expand Down Expand Up @@ -65,6 +67,10 @@ def bucket_sort(my_list: list, bucket_count: int = 10) -> list:
True
>>> bucket_sort([1]) == [1]
True
>>> bucket_sort([1, 2, 3], 2.5)
Traceback (most recent call last):
...
TypeError: bucket_count must be an integer
>>> data = [-1.1, -1.5, -3.4, 2.5, 3.6, -3.3]
>>> bucket_sort(data) == sorted(data)
True
Expand All @@ -73,6 +79,8 @@ def bucket_sort(my_list: list, bucket_count: int = 10) -> list:
True
"""

if not isinstance(bucket_count, int):
raise TypeError("bucket_count must be an integer")
if len(my_list) == 0 or bucket_count <= 0:
return []

Expand Down
Loading