Repository navigation
Reviewer: point the guide's diff instructions at the file the harness writes - #55
Conversation
… writes The guide still told the agent to run `gh pr diff` and to diff against `origin/main`, which the hardened harness made impossible: `gh` is not on the sandbox's command allowlist, the agent holds no GitHub token, and the PR checkout is shallow with no base ref. The harness prefetches the diff into a file and names it in the task prompt, so the guide now says that, matching the android and support-pipeline guides.
✅ Claude PR Review —
|
What
review-guide.mdstill carried two instructions from the first-generation reviewer that the hardened harness (#40) makes impossible:origin/main": the PR checkout is shallow (fetch-depth: 1), so there is no base ref.gh pr diff <number>":ghis not on the sandbox's command allowlist, and the agent holds no GitHub token.Each review round therefore started with a denied command before the agent found the diff file the task prompt names. The guide now says what the harness actually does, matching the android and support-pipeline guides (and the iOS port in TortugaPower/BookPlayer#1611, which carried the same stale lines).
Only
review-guide.mdchanges. Underpull_request_target, this PR is reviewed withmain's current guide; the new wording takes effect on PRs opened after the merge.Verification
node --test test/in.github/claude/reviewer/: 247/247. Theharness-testsjob runs on this PR because it touches.github/claude/.🤖 Generated with Claude Code