Skip to content

Reviewer: point the guide's diff instructions at the file the harness writes #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GianniCarlo merged 1 commit into from
Oct 6, 2026
Merged

Reviewer: point the guide's diff instructions at the file the harness writes #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/claude/review-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ controller→service→DB-class convention, naming rules, and request flow. Judg
This service handles **per-user data, auth, and money** (Apple/Google/RevenueCat subscriptions), so
security and authorization bugs are the highest-priority findings.

**Main branch is `main`.** Diff against `origin/main`.
**Main branch is `main`.** The harness hands you the pull request's unified diff as a file. The checkout is the
PR head only (`fetch-depth: 1`): there is no `origin/main` ref and no `gh` access inside the review, and
`git log` / `git blame` see only the head commit.

## How to review

1. Get the diff: `gh pr diff <number>`. The branch is checked out in the working directory.
1. Read the unified diff the harness wrote for you; its path is in the task prompt. The PR branch is already
checked out in the working directory.
2. **Do not review the diff in isolation.** For each non-trivial change, open the surrounding code and
its **callers** with `Read`/`Grep`/`Glob` before judging. Diff-only opinions are not acceptable.
For a new/changed route, always open the router to confirm which middlewares (`auth`,
Expand Down
Loading