Fix various small type inconsistencies - #181
Open
domWalters wants to merge 4 commits into
Open
domWalters wants to merge 4 commits into
domWalters wants to merge 4 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
domWalters
changed the title
Member
|
I'll check it later when I'm back. but it looks good. Please direct further PRs to |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered the following issues as I added features to
pyVHDLModelTreesitter, identified in most cases by both themypyandtystatic type checker tools.Technically, all of these changes are "API Breaking" w.r.t. announced types, however they all fix legitimate typing inconsistencies where a child class incorrectly changes the type of an attribute inherited from a base class.
Bug Fixes
Symbols in the mixin.