Skip to content

Fix various small type inconsistencies #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domWalters wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Fix various small type inconsistencies #181

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29c31e8
v0.39.0 (#168)
Paebbels Aug 4, 2026
3b9d3cb
fix: labels are optional on concurrent procedures and signal assignments
domWalters Aug 28, 2026
3cf0a15
fix: messages in assertion statements are optional
domWalters Aug 28, 2026
d386394
fix: procedure names are symbols
domWalters Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions pyVHDLModel/Concurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
from pyVHDLModel.Common import ConditionalWaveformsMixin, WaveformMixin
from pyVHDLModel.Common import ExpressionMixin, SelectedWaveformsMixin
from pyVHDLModel.Sequential import SequentialStatement, SequentialStatementsMixin
from pyVHDLModel.Symbol import Symbol


ExpressionUnion = Union[
Expand Down Expand Up @@ -454,8 +455,8 @@ class ConcurrentProcedureCall(ConcurrentStatement, ProcedureCallMixin):
"""
def __init__(
self,
label: str,
procedureName: Name,
label: Nullable[str],
procedureName: Symbol,
parameterAssociationItems: Nullable[Iterable[ParameterAssociationItem]] = None,
parent: Nullable[ModelEntity] = None
) -> None:
Expand Down Expand Up @@ -1376,7 +1377,7 @@ class ConcurrentSignalAssignment(ConcurrentStatement, SignalAssignmentMixin):
* :class:`Concurrent simple signal assignment <pyVHDLModel.Concurrent.ConcurrentSimpleSignalAssignment>`
* :class:`Concurrent selected signal assignment <pyVHDLModel.Concurrent.ConcurrentSelectedSignalAssignment>`
* :class:`Conditional signal assignment <pyVHDLModel.Concurrent.ConcurrentConditionalSignalAssignment>` """
def __init__(self, label: str, target: SignalSymbol, parent: Nullable[ModelEntity] = None) -> None:
def __init__(self, label: Nullable[str], target: SignalSymbol, parent: Nullable[ModelEntity] = None) -> None:
"""
Initializes a concurrent signal assignment.

Expand Down Expand Up @@ -1408,7 +1409,7 @@ class ConcurrentSimpleSignalAssignment(ConcurrentSignalAssignment, WaveformMixin

* :class:`Sequential counterpart <pyVHDLModel.Sequential.SequentialSimpleSignalAssignment>`
"""
def __init__(self, label: str, target: SignalSymbol, waveform: Iterable[WaveformElement], parent: Nullable[ModelEntity] = None) -> None:
def __init__(self, label: Nullable[str], target: SignalSymbol, waveform: Iterable[WaveformElement], parent: Nullable[ModelEntity] = None) -> None:
"""
Initializes a simple concurrent signal assignment.

Expand Down Expand Up @@ -1449,7 +1450,7 @@ class ConcurrentSelectedSignalAssignment(ConcurrentSignalAssignment, ExpressionM

def __init__(
self,
label: str,
label: Nullable[str],
target: SignalSymbol,
expression: ExpressionUnion,
selectedWaveforms: Iterable[SelectedWaveform],
Expand Down Expand Up @@ -1496,7 +1497,7 @@ class ConcurrentConditionalSignalAssignment(ConcurrentSignalAssignment, Conditio

def __init__(
self,
label: str,
label: Nullable[str],
target: SignalSymbol,
conditionalWaveforms: Iterable[ConditionalWaveform],
parent: Nullable[ModelEntity] = None
Expand Down Expand Up @@ -1538,7 +1539,7 @@ class ConcurrentAssertStatement(ConcurrentStatement, AssertStatementMixin):
def __init__(
self,
condition: ExpressionUnion,
message: ExpressionUnion,
message: Nullable[ExpressionUnion] = None,
severity: Nullable[ExpressionUnion] = None,
label: Nullable[str] = None,
parent: Nullable[ModelEntity] = None
Expand Down