P02: complete RunManifestV1 selection and diagnostic contracts - #28
Closed
ajhcs wants to merge 4 commits into
Closed
P02: complete RunManifestV1 selection and diagnostic contracts#28ajhcs wants to merge 4 commits into
ajhcs wants to merge 4 commits into
Conversation
Add return_contract.allow_diagnostic_partial_candidate, the sole optional RunManifestV1 return-contract key: an exact primitive boolean with no aliases, defaults, or coercion. Absent and false keep complete-only behavior; true only permits a later P35A diagnostic incomplete_candidate and never obligates one. The submitted frozen form is preserved, so an explicit false remains an own key and carries its own raw RunManifestV1 digest distinct from absence. The flag is resolution-inert: it never enters assignment prompts, ChildEnvelopeV1 bytes, or child-envelope digests; P35A/P36 alone own any later candidate status or disposition.
P05 reachability prerequisite, bounded to P02 validation only. A run may
bind one optional root profile NAME (profile) validated with the exact
already-owned assignment execution.profile grammar; no P04 catalog import
or lookup happens here. Assignment execution may now be truly absent: the
lane becomes selection_resolution_required for the later P05 resolver,
the same classification a named-profile lane already carries, while every
present hostile form (null, {}, own undefined, partial pairs, unknown
grammars) keeps failing closed exactly as before and explicit
provider/model lanes stay dispatch-resolved. The frozen envelope summary
gains bound_root_profile plus selection_resolution_required(_assignment_
ids); legacy profile fields keep their semantics. Parsing still returns
detached deeply frozen graphs with submitted presence preserved, so
existing manifests and all canonical/run/child digests remain
byte-identical. No role/access/duration/starting_ref/repository field
becomes optional.
Compiling a child envelope for a lane whose execution was omitted now raises the typed RunContractV1Error selection_resolution_required at assignments[<i>].execution before any routing field is read. The compiler guesses no provider/model, renders no unresolved worker prompt, and emits no partial batch; named-profile and explicit lanes keep compiling byte-identically, and identity digests stay computable for runs the compiler correctly refuses to render.
Owner
Author
|
Closing as rejected and superseded evidence. Exact head |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Completes the bounded P02 manifest and selection contract repair for the 3.3.0 R1 candidate.
Commit and size bounds
Acceptance evidence
Independent Ox Alpha exact-head review: ACCEPT.
Verified invariants include absent versus false diagnostic normalization, true diagnostic distinction, root profiles resolving no assignments, omitted execution remaining unresolved, failure before compilation, one shared selection grammar, and hostile direct-JavaScript handling.
Integration policy
This PR intentionally remains unmerged. Its exact reviewed commits are composed only into the isolated combined candidate. Default-branch integration is permitted after the functional Gate A passes and final Codex review approves the exact candidate.