server: exclude webserver/apache2 check in VPC VR without tiers

[weizhouapache]

Description

This PR refactores #11190

logs show apache2 service is excluded in the router health check

2026-05-22 08:51:37,940 DEBUG [c.c.a.t.Request] (RouterStatusMonitor-1:[ctx-0aaf1866]) (logid:9c7a5c66) Seq 1-2002412984319607143: Sending { Cmd , MgmtId: 32985902482535, via: 1(ref-trl-10000-k-Mu24-wei-zhou-kvm1), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.routing.SetMonitorServiceCommand":{"healthChecksConfig":{"gateways":"gatewaysIps=169.254.0.1 10.0.48.1 ","portForwarding":"","systemThresholds":"minDiskNeeded=100.0,maxCpuUsage=100.0,maxMemoryUsage=100.0;","haproxyData":"","virtualMachines":"","routerVersion":"templateVersion=Cloudstack Release 4.22.0 Fri Oct 3 08:20:09 AM UTC 2025,scriptsVersion=8c8bf4fd7c7c39084206d0a9b1c27612d41bc019d98b722aa7bacfc4245c01e6191a9c8c98457e2740f072139ee9bbab3ee8c59e5e59701617c296807c96ab10"},"reconfigureAfterUpdate":"true","deleteFromProcessedCache":"true","accessDetails":{"router.name":"r-610-VM","router.health.checks.advanced.interval":"10","router.health.checks.enabled":"true","router.health.checks.basic.interval":"3","router.health.checks.excluded":"apache2","router.ip":"169.254.222.103"},"wait":"0","bypassHostMaintenance":"false"}}] }

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (d1e1aa5) to head (73f4929).
⚠️ Report is 74 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #13219      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
- Complexity    15791    15792       +1     
============================================
  Files          5922     5922              
  Lines        533127   533130       +3     
  Branches      65205    65207       +2     
============================================
- Hits          94243    94242       -1     
- Misses       428239   428241       +2     
- Partials      10645    10647       +2     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.75% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17985

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16164)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 47540 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13219-t16164-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

Suggested change

	excludedTests = excludedTests.isEmpty() ? webserverServiceName : excludedTests + "," + webserverServiceName;
	if (excludedTests.isEmpty()) {
	excludedTests = webserverServiceName;
	} else if (! excludedTests.contains(webserverServiceName)) {
	excludedTests += "," + webserverServiceName;
	}

[nagaboinaramgopal]

@weizhouapache I tried a VPC without tiers on a clean 4.22 branch setup (KVM, 4.22.0 systemvm template), without this change.

The router only gets ssh in its monitor config. The health check results show no FAILED checks and no alert is raised. dhcp_check.py reports UNKNOWN, which I think is intended since #10710. So I could not reproduce the webserver.service alert from #10088 on 4.22.

Also, as far as I can see, excluded_health_checks is only applied to the scripts in /root/health_checks in monitorServices.py. The service checks from monitProcess() (for example webserver.service) do not look at it, and the name added here is apache2, not webserver.service.

Could you share the steps to get the webserver.service failure? I will reproduce them in my lab and test this PR with and without the change.

[weizhouapache]

@weizhouapache I tried a VPC without tiers on a clean 4.22 branch setup (KVM, 4.22.0 systemvm template), without this change.

The router only gets ssh in its monitor config. The health check results show no FAILED checks and no alert is raised. dhcp_check.py reports UNKNOWN, which I think is intended since #10710. So I could not reproduce the webserver.service alert from #10088 on 4.22.

I remember I faced a similar issue in recent release but I forget the details. I will update you later

Also, as far as I can see, excluded_health_checks is only applied to the scripts in /root/health_checks in monitorServices.py. The service checks from monitProcess() (for example webserver.service) do not look at it, and the name added here is apache2, not webserver.service.

the monitor service "webserver" is actually mapped to the apache2 service inside VR

*************************** 1. row ***************************
          id: 4
        uuid: bcb5744a-ba1a-11f0-9974-1e00b5000454
     service: webserver
process_name: apache2
service_name: apache2
service_path: /etc/init.d/apache2
     pidfile: /var/run/apache2/apache2.pid
   isDefault: 1
1 row in set (0.00 sec)

Could you share the steps to get the webserver.service failure? I will reproduce them in my lab and test this PR with and without the change.