ui: fix physical network guest traffic type tab - #6096
Merged
Merged
Conversation
Fixes icon Fixes object change Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
yadvr
approved these changes
Mar 11, 2022
|
UI build: ✔️ |
utchoang
reviewed
Mar 11, 2022
| }, | ||
| watch: { | ||
| network (newItem, oldItem) { | ||
| resource (newItem, oldItem) { |
There was a problem hiding this comment.
@davidjumani With Vue3, to watch an Object, you should use deep. Refer: https://vuejs.org/guide/essentials/watchers.html#deep-watchers
Contributor
Author
There was a problem hiding this comment.
@utchoang Doc says deep is needed only in cases where trying to run callback on all nested mutations. Even there example runs fine without it and I don't think we want to run fetchData here on any property change of resource
utchoang
approved these changes
Mar 14, 2022
davidjumani
approved these changes
Mar 14, 2022
sureshanaparti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes icon
Fixes object change
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before
After
How Has This Been Tested?