Skip to content

ui: fix physical network guest traffic type tab #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weizhouapache merged 1 commit into from
Mar 14, 2022
Merged

ui: fix physical network guest traffic type tab #6096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ui/src/views/infra/network/IpRangesTabGuest.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
:rowKey="record => record.id"
:pagination="false"
>
<template #name="{ text }">
<resource-icon v-if="item.icon" :image="item.icon.base64image" size="1x" style="margin-right: 5px"/>
<template #name="{ text, record }">
<resource-icon v-if="record.icon" :image="record.icon.base64image" size="1x" style="margin-right: 5px"/>
<apartment-outlined v-else style="margin-right: 5px"/>
<router-link :to="{ path: '/guestnetwork/' + item.id }">
<router-link :to="{ path: '/guestnetwork/' + record.id }">
{{ text }}
</router-link>
</template>
Expand Down Expand Up @@ -137,7 +137,7 @@ export default {
this.fetchData()
},
watch: {
network (newItem, oldItem) {
resource (newItem, oldItem) {

@utchoang utchoang Mar 11, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani With Vue3, to watch an Object, you should use deep. Refer: https://vuejs.org/guide/essentials/watchers.html#deep-watchers

@shwstppr shwstppr Mar 11, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utchoang Doc says deep is needed only in cases where trying to run callback on all nested mutations. Even there example runs fine without it and I don't think we want to run fetchData here on any property change of resource

if (!newItem || !newItem.id) {
return
}
Expand Down