Skip to content

Fix test_vm_schedule's intermittent failures - #7726

Merged
yadvr merged 2 commits into
apache:mainfrom
shapeblue:fix-smoke-vmschedule
Jul 7, 2023
Merged

yadvr merged 2 commits into
apache:mainfrom
shapeblue:fix-smoke-vmschedule

Conversation

@vishesh92

Copy link
Copy Markdown
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@boring-cyborg boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Jul 6, 2023
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a more sturdy way of checking in nested environments, let's test a few times.

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6424

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@codecov

codecov Bot commented Jul 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7726 (62d22a0) into main (02be2cd) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7726      +/-   ##
============================================
- Coverage     13.39%   13.38%   -0.02%     
- Complexity     9347     9507     +160     
============================================
  Files          2743     2743              
  Lines        258553   263332    +4779     
  Branches      40281    42458    +2177     
============================================
+ Hits          34646    35255     +609     
- Misses       219533   223614    +4081     
- Partials       4374     4463      +89     

see 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishesh92

Copy link
Copy Markdown
Member Author

I added test_vm_schedule as part of github actions.
@DaanHoogland Can you rerun this workflow Simulator CI / build (smoke/test_router_dhcphosts smoke/test_router_dns smoke/test_router_dnsservice smoke/...?

@DaanHoogland DaanHoogland reopened this Jul 6, 2023
@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-7002)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46881 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7726-t7002-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_07_deploy_kubernetes_ha_cluster Failure 3612.52 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.05 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 94.78 test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume Error 77.56 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 55.38 test_vm_life_cycle.py

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland DaanHoogland reopened this Jul 7, 2023
@yadvr yadvr added this to the 4.19.0.0 milestone Jul 7, 2023
@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-7014)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7726-t7014-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 79.70 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 56.51 test_vm_life_cycle.py

@yadvr
yadvr merged commit c956d32 into apache:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants