Skip to content

Fix test_vm_schedule's intermittent failures #7726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 2 commits into from
Jul 7, 2023
Merged

Fix test_vm_schedule's intermittent failures #7726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
987eeae
Fix test_vm_schedule's intermittent failures
vishesh92 Jul 6, 2023
62d22a0
Add smoke/test_vm_schedule to CI
vishesh92 Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ jobs:
smoke/test_usage
smoke/test_usage_events
smoke/test_vm_deployment_planner
smoke/test_vm_schedule
smoke/test_vm_life_cycle
smoke/test_vm_lifecycle_unmanage_import
smoke/test_vm_snapshot_kvm
Expand Down
13 changes: 8 additions & 5 deletions test/integration/smoke/test_vm_schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,13 +530,13 @@ def test_05_vmschedule_test_e2e(self):
)
self.assertNotEqual(len(vmschedules), 0, "Check VM Schedule is created")

# poll every 20 seconds (max waiting time is 4 minutes ) and check VM's state for changes
# poll every 10 seconds (max waiting time is 6 minutes) and check VM's state for changes
previous_state = self.virtual_machine.state
self.debug("VM state: %s" % self.virtual_machine.state)
is_stop_schedule_working = False
is_start_schedule_working = False
for i in range(0, 12):
time.sleep(20)
for i in range(0, 36):
time.sleep(10)
current_state = self.virtual_machine.update(self.apiclient).state
self.debug("Polling VM state: %s" % current_state)
if previous_state in ("Running", "Starting") and current_state in (
Expand Down Expand Up @@ -570,6 +570,9 @@ def test_05_vmschedule_test_e2e(self):
start_vmschedule.delete(self.apiclient)
stop_vmschedule.delete(self.apiclient)

# To ensure that all vm schedules have been deleted and all of their jobs have been completed
time.sleep(15)

# Verify VM Schedule is deleted
self.assertEqual(
VMSchedule.list(
Expand All @@ -586,10 +589,10 @@ def test_05_vmschedule_test_e2e(self):
"Check VM Schedule is deleted",
)

# Verify VM does not switch states after deleting schedules at least for 1.5 minutes
# Verify VM does not switch states after deleting schedules at least for 2 minutes
previous_state = self.virtual_machine.update(self.apiclient).state
state_changed = False
for i in range(0, 3):
for i in range(0, 4):
time.sleep(30)
current_state = self.virtual_machine.update(self.apiclient).state
if previous_state != current_state:
Expand Down