Set encrypted PowerFlex disk format correctly

[mlsorensen]

Description

This PR:

1. Sets disk format correctly according to thin/thick provisioned PowerFlex volumes when encryption is in play. It delegates the volume format to the implementation (ScaleIOStorageAdaptor) and ensures it is passed back so it is stored properly in the VolumeVO.

This allows us to trigger the code that resizes the qcow2 container if we are thin provisioned - this wasn't working for data volumes when VM was stopped because they were hard coded to RAW format.

2. Defensive coding in case volume has no VM instance name (detached)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally against powerflex, both detached and attached volume.

[yadvr]

LGTM didn't test it though

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6437

[harikrishna-patnala]

Thanks @mlsorensen

putting the same reply here as the old PR again here, not to miss that.

Code LGTM. It's better to test all the volume operations since we are dealing with volume format here.

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7038)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44522 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7735-t7038-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	83.91	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	54.51	test_vm_life_cycle.py

[borisstoyanov]

@mlsorensen, I'm running into some strange issues while testing this, seems like it does not have the latest changes.

@harikrishna-patnala is looking if he can rebase the branch

[harikrishna-patnala]

@mlsorensen can you please rebase the branch with latest 4.18, we are missing the new changes to allow migrations in this branch.

[harikrishna-patnala]

@borisstoyanov I just verified, this branch has the new changes that allow migraiton of volumes, can we double check if we got the latest packages from this PR and also can you check if all the management servers are upgraded with the latest PR packages.

[harikrishna-patnala]

@mlsorensen can you please rebase the branch with latest 4.18, we are missing the new changes to allow migrations in this branch.

You may please ignore this comment, I just verified the file changes it seems to be at latest.

[borisstoyanov]

@blueorangutan package

[blueorangutan]

@borisstoyanov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6530

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7134)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41544 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7735-t7134-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	80.83	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	51.41	test_vm_life_cycle.py

[blueorangutan]

[SF] Trillian test result (tid-7139)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48646 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7735-t7139-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_create_pvlan_network	Error	0.05	test_pvlan.py
test_01_migrate_VM_and_root_volume	Error	77.75	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	52.51	test_vm_life_cycle.py

[borisstoyanov]

LGTM, manually tested this executing Volume related lifecycle operations on power flex and other storage types.

[weizhouapache]

code lgtm
not tested yet