Repository navigation
Conversation
This was referenced Oct 25, 2026
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #1309. Preserve both signed-zero endpoints when the float64 L2 reference orders an interval whose ends compare equal to zero. This prevents an x86_64 reference interval from rejecting the exact
+0returned by the Dory activation kernels.The change touches only the reference helper and a raw-bit regression. Same-sign zeros retain their signs; NaN handling, nonzero bounds, kernels and contract tolerances are unchanged.
Receipt
67cc8fbce879e2d0dd74b94ebb8848b134478ee4, native version 1.1.4, Zig 0.17.0, Linux x86_64 and aarch64; device checks on RTX PRO 4500 Blackwell (SM120), CUDA compiler 13.0.88. No checkpoint/model revision applies to these synthetic kernel/reference tests.84e0d560; this release changes version/docs only.zig/andbuild.zigare unchanged from the tested base, and the branch merges cleanly. The test receipts remain labelled native 1.1.4.corealso re-exports the reference. No runtime call sites were found.DIAGNOSTIC SUMMARY kernels=2 passed=2 failed=0 controls=4 caught=4 missed=0. Before the correction: 0 kernels passed, 2 failed, with all 4 controls caught in each of two isolated runs. These are wrapper summaries, not full official-runner summaries.zig build test -j2 --summary allpasses on both architectures, each with 366/366 steps succeeded, 4,197 passed, 17 skipped, 0 failed. The aggregate reports 17 skips on each architecture; its log explicitly identifies unavailable libjpeg-turbo and libwebp pixel cases, but does not enumerate every skipped test.e0c2ced997f66016d4a26022fa66f8fbd9eab0d7cec5b0f3b6c78ae9e94a7c1d, matchingzig/src/core/l2_ref.zigin commita3ce6a2f3d1d65094dcf32452fb8e8a4ce826814.l2_refpassed gates 1–4:tf_l2_rows(plain and add),tf_slerp_rows,tf_qk_rows_l2,tf_gate_l2_rowsandtf_swiglu_l2_rows. Their planted controls remained caught.SUMMARYline. It stopped after the window_rows decode-256 registration; the next registration prepares a zero-prefix prompt. The trap maps tocontract_window_rows.zig:183, whose decode-position fixture evaluates modulo zero for that prompt. Those files do not usel2_ref; an isolated wrapper reproduced the crash twice with the original, unchanged window_rows fixture. This separate fixture bug (reported as kernel-contract: window_rows prompt fixture computes modulo zero for empty prefixes #1316; fixed by draft cuda tests: guard prompt positions in window rows fixtures #1318) does not establish an incorrect model or GPU-kernel result. Two Qwen attention nonfinite failures were followed immediately by matching registeredKNOWNlines; no other unexpected failure lines were emitted before the crash. This is not a complete GPU-suite pass or device qualification.SUMMARY. It passed the former zero-prefix crash and stopped afterrepeat cuda wide branch dim512 GQA16 mode1. The emitted lines contain 1,197 PASS, 82 caught corruption controls, two immediately matching registered KNOWN nonfinite cases and 43 N/A gate entries; no unexpected non-control FAIL or missed/error control was emitted. These are partial emitted-line counts, not a full-suite kernel summary. No global pass or device qualification is claimed. The immutable image wassha256:3e80f691fe02f524b29e677173a9b62e460b21c1487b8eb867dd135b81f9f105; driver 615.78.08, NVCC 13.0.88, RTX PRO 4500 SM120. The combined runner includes fixture commit7b04b5edcba1e146cc98c5bcbf14965917c6beca, file SHA256c940ab265f2e2afe48d88ca5ce442295f434f4cd2e6214dc24c63761bd11660c, and unmerged l2_ref: preserve signed-zero interval endpoints #1315 commita3ce6a2f3d1d65094dcf32452fb8e8a4ce826814, reference file SHA256e0c2ced997f66016d4a26022fa66f8fbd9eab0d7cec5b0f3b6c78ae9e94a7c1d. This is combined-run evidence, not a fixture-candidate-alone full-suite pass.1e-6) contained its exact points in all 28,672 cases on each architecture. An instrumented ARM replay evaluated 73,728 positive-epsilon finite zero-padding corners (corner evaluations, not cases); all 112 excluded zero-epsilon NaN misses had exactly zero row sum of squares. This does not qualify zero-epsilon normalization, which has a separate singularity.git diff --checkpasses.Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo. (n/a: reference-only)SUMMARYline is in the receipt. (n/a: no kernel change)