Repository navigation
Conversation
This was referenced Oct 25, 2026
Owner
|
Thank you @Maxrio9. The same guard is on main as 3cb8cb5 (landed in 84e0d56..24072ec with your #1315 and #1308): prompt rows in the window_rows fixture now sit at - Synthema, Ash's AI Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #1316. Prepare prompt positions as
at + i, matching the fixture'sp0, before considering decode-only position arithmetic. This avoids modulo zero for the existing valid zero-prefix prompt cases and mirrors the sibling window-attention fixture.One line changes in the contract fixture. Decode-position coverage, GPU kernels and contract tolerances are unchanged.
Receipt
67cc8fbctree with the candidate fixture overlaid; this fixture and its dependencies are identical in84e0d560. The overlaid file SHA256 isc940ab265f2e2afe48d88ca5ce442295f434f4cd2e6214dc24c63761bd11660c, matching commit7b04b5edcba1e146cc98c5bcbf14965917c6beca.84e0d560(native source version 1.1.5), Zig 0.17.0; Linux x86_64 and aarch64 host checks; RTX PRO 4500 Blackwell (SM120), CUDA compiler 13.0.88. Synthetic fixtures only; checkpoint/model revision n/a.Rows.prepare:183. A ReleaseSafe probe reports integer division by zero. A copied expression reports division by zero in Debug on both CPU architectures; the ReleaseFast ARM result does not make modulo zero valid.WROWS DIAGNOSTIC SUMMARY kernels=3 passed=3 failed=0 controls=6 caught=6 missed=0. This covers decode, zero/nonzero prefixes, P32/image prompts, BF16-P prompts and six corruption controls. This is a wrapper summary, not a full official-runner summary.zig build test-window-rows-host -j2 --summary allreports 4/4 steps and 8/8 tests passed on each architecture, 0 failed, 0 skipped. The existing zero-prefix device cases supply the regression; no new test is added.git diff --checkpasses.SUMMARY. It passed the former zero-prefix crash and stopped afterrepeat cuda wide branch dim512 GQA16 mode1. The emitted lines contain 1,197 PASS, 82 caught corruption controls, two immediately matching registered KNOWN nonfinite cases and 43 N/A gate entries; no unexpected non-control FAIL or missed/error control was emitted. These are partial emitted-line counts, not a full-suite kernel summary. No global pass or device qualification is claimed. The immutable image wassha256:3e80f691fe02f524b29e677173a9b62e460b21c1487b8eb867dd135b81f9f105; driver 615.78.08, NVCC 13.0.88, RTX PRO 4500 SM120. The combined runner includes fixture commit7b04b5edcba1e146cc98c5bcbf14965917c6beca, file SHA256c940ab265f2e2afe48d88ca5ce442295f434f4cd2e6214dc24c63761bd11660c, and unmerged l2_ref: preserve signed-zero interval endpoints #1315 commita3ce6a2f3d1d65094dcf32452fb8e8a4ce826814, reference file SHA256e0c2ced997f66016d4a26022fa66f8fbd9eab0d7cec5b0f3b6c78ae9e94a7c1d. This is combined-run evidence, not a fixture-candidate-alone full-suite pass.Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo. (n/a: fixture-only)SUMMARYline is in the receipt. (n/a: no kernel change)