Repository navigation
Adding functionality to insert until confluence - #236
Merged
Merged
Conversation
…me location until max density is reached
allison-li-1016
requested review from
a team,
Jannetty,
afu5,
cainja,
daniellevahdat,
jacob-evarts,
jessicasyu and
kristaphommatha
and removed request for
a team
September 21, 2026 21:25
Jannetty
reviewed
Sep 30, 2026
Jannetty
reviewed
Sep 30, 2026
Jannetty
reviewed
Sep 30, 2026
Jannetty
reviewed
Sep 30, 2026
Jannetty
approved these changes
Sep 30, 2026
Jannetty
left a comment
Member
There was a problem hiding this comment.
LGTM! Made some suggestions mostly for logging when the code defaults to something other than what the user specified. At some point I think it could be nice to have the ability to insert intermediate numbers of cells to each location (values other than 1 and the max), but I don't think that has to be in this PR. Great work!
kristaphommatha
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just a small thing about the way the confluence parameter is read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review time: s
Context: Currently insert only adds 1 cell per location. Certain cell types allow multiple cells to occupy the same location. I want to add the option to insert cells into the same location until the cell's density limit is reached.
Summary of changes:
InsertclassPatchCellclassExample usage: