Repository navigation
feat(integrations): list OMP models from omp models or a throwaway session - #705
Closed
bandzalkin wants to merge 1 commit into
Closed
bandzalkin wants to merge 1 commit into
bandzalkin wants to merge 1 commit into
Conversation
This was referenced Sep 29, 2026
bandzalkin
changed the title
AlexanderZ-Band
force-pushed
the
feat/host-list-models-omp
branch
from
September 30, 2026 06:41
8fb001e to
5578025
Compare
AlexanderZ-Band
added this pull request to stack #766
October 10, 2026 06:21
Hosts need the models this OMP install offers without a model turn. Read omp models --json, and when that command is missing fall back to the model and thinking selects on a throwaway ACP session.
AlexanderZ-Band
force-pushed
the
feat/host-list-models-omp
branch
from
October 10, 2026 06:32
ef2ac94 to
919d236
Compare
Contributor
Author
|
Superseded by #848, refreshed on current upstream main with a fork-owned maintenance branch. The replacement records the corrected behavior, actual dependencies, own-delta review/replay base, local verification, and the private-core coverage limitation for fork PRs. This closes the superseded proposal only: no merge, fork-main integration, or source-branch deletion. Original PR history and branch are retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hosts can ask an OMP install which models it offers, with no model turn and no room session.
Changes
band.adapters.omp_acp.list_modelsrunsomp models --jsonand parsesselectoras the model id.modelandthinkingconfigOptions. The thinking levels apply only to the session's current model. The process is closed on every path, including cancellation.Related Issues
Split out of #666 (S-13). Stacked on #704 (
feat/host-list-models-codex); review and merge that first.Testing
uv run pytest tests/ --ignore=tests/integration/ --ignore=tests/e2e/)ruff check,ruff format --check,pyrefly check)pytest --markdown-docs docs)ompCLI is parsed, a failed CLI falls back to session selects, and cancellation still closes the session process. 5959 passed.Checklist