Repository navigation
fix: isolate room cancellation during bridge rehydration - #833
Open
AlexanderZ-Band wants to merge 3 commits into
Open
AlexanderZ-Band wants to merge 3 commits into
AlexanderZ-Band wants to merge 3 commits into
Conversation
This was referenced Oct 18, 2026
AlexanderZ-Band
commented
Oct 18, 2026
AlexanderZ-Band
left a comment
Collaborator
Author
There was a problem hiding this comment.
Full-PR review at ab4f7cd0813a: no verified findings across Style & Hygiene, Design & Reuse, Runtime Safety & Observability, Test Quality, Edge-Case Flow Analysis, or Logical Bugs. Converged in cycle 1. Bridge suite: 93 passed; complete unit suite is running.
There was a problem hiding this comment.
🟢 Approved
The localized change preserves runner cancellation, adds focused regression coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Isolates room-level cancellation and failures during bridge startup rehydration, while preserving cancellation of the runner itself.
Changes:
- Collects and logs rehydration outcomes per room.
- Adds startup cancellation and failure regression tests.
- Splits existing bridge tests by behavior and centralizes shared helpers.
| File | Description |
|---|---|
| tests/bridge/test_rehydration_failure.py | Tests failure isolation and logging. |
| tests/bridge/test_rehydration_control.py | Tests room and runner cancellation during startup. |
| tests/bridge/test_control_wiring.py | Relocates control-hook wiring tests. |
| tests/bridge/test_control_routing.py | Relocates control-scope routing tests. |
| tests/bridge/test_control_play_nudge.py | Relocates play-triggered backlog tests. |
| tests/bridge/test_control_graceful_degradation.py | Relocates defensive control tests. |
| tests/bridge/test_control_dedup.py | Relocates control deduplication tests. |
| tests/bridge/test_control_cancels_in_flight_forward.py | Relocates forwarding cancellation tests. |
| tests/bridge/test_bridge.py | Removes the consolidated suite after splitting it. |
| tests/bridge/test_bridge_control.py | Removes the consolidated control suite after splitting it. |
| tests/bridge/test_band_bridge_shutdown.py | Relocates shutdown tests. |
| tests/bridge/test_band_bridge_multi_identity_isolation.py | Relocates agent-isolation tests. |
| tests/bridge/test_band_bridge_construction.py | Relocates bridge construction tests. |
| tests/bridge/test_agent_runner_subscriptions.py | Relocates subscription and cleanup tests. |
| tests/bridge/test_agent_runner_rehydration.py | Relocates backlog rehydration tests. |
| tests/bridge/test_agent_runner_per_room_serialization.py | Relocates room serialization tests. |
| tests/bridge/test_agent_runner_forwarding.py | Relocates event-forwarding tests. |
| tests/bridge/test_agent_runner_forwarder_failures.py | Relocates forwarder failure tests. |
| tests/bridge/test_agent_runner_concurrency_cap.py | Relocates forwarding concurrency-limit tests. |
| tests/bridge/test_agent_runner_backoff.py | Relocates reconnect jitter tests. |
| tests/bridge/kit.py | Centralizes runner builders, events, and test doubles. |
| band-bridge/bridge_core/bridge.py | Collects room outcomes without propagating individual nudge cancellation. |
Review effort: Balanced
…ring-bridg-INT-1843
AlexanderZ-Band
enabled auto-merge
October 20, 2026 08:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cancelling one room's startup nudge can propagate through backlog rehydration and shut down the whole bridge.
What
Collect and report each room's rehydration result independently. Organize the bridge tests by behavior and cover cancellation and failure without abandoning other rooms.
Scope
Independent bridge portion of #791. Closes INT-1843; contributes to INT-1133. Backend cancellation and runtime queue handling remain separate changes.
Runtime controls are #832; backend cancellation is #834 → #835 → #791.