Repository navigation
fix: own backend turn cancellation across ACP and native adapters - #834
Merged
AlexanderZ-Band merged 4 commits intoOct 19, 2026
Merged
AlexanderZ-Band merged 4 commits into
AlexanderZ-Band merged 4 commits into
Conversation
AlexanderZ-Band
added this pull request to stack #836
October 18, 2026 04:02
This was referenced Oct 18, 2026
AlexanderZ-Band
commented
Oct 18, 2026
AlexanderZ-Band
left a comment
AlexanderZ-Band
left a comment
Collaborator
Author
There was a problem hiding this comment.
Blocking — would be REQUEST_CHANGES on a PR by someone else. Full-PR cycle 1 found one verified issue; root-cause fix and regression validation follow.
AlexanderZ-Band
commented
Oct 18, 2026
AlexanderZ-Band
left a comment
AlexanderZ-Band
left a comment
Collaborator
Author
There was a problem hiding this comment.
Full-PR cycle 2: no verified findings across all six review groups. Converged after fixing the cycle-1 issue. Focused boundary checks pass; combined full-unit validation is still running.
AlexanderZ-Band
deleted the
fix/fixpython-own-backend-turn-cancellation-across-acp-INT-1841
branch
October 19, 2026 08:39
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cancelling a local handler does not necessarily stop work accepted by an external backend, and replacement turns must wait for the prior stop to settle.
What
Introduce BackendTurns with owned, bounded cancellation, late-handle binding and settlement barriers. Integrate ACP and its inherited adapters, Cursor ACP, Codex and Claude SDK with the retained-room lifecycle. Add RetainedRoom.wait_released() so Claude cancellation joins the existing physical-close owner, with primitive tests and protocol/process probes.
Scope
Bottom layer of the backend cancellation stack split from #791. Closes INT-1841; contributes to INT-1133. The conformance guard covers migrated adapters; subsequent layers add the remaining backends and the complete exported-adapter inventory guard. Runtime and bridge fixes are independent.
Stack: #834 → #835 → #791. Independent fixes: runtime #832 and bridge #833.