feat(mcp): resolve room-scoped servers at native OMP connection startup by bandzalkin · Pull Request #854 · band-ai/band-sdk-python

bandzalkin · 2026-10-19T02:45:51Z

Summary

This resolves external MCP servers when each native OMP room connection starts, so a new connection uses the current room-scoped servers and credentials rather than a static adapter-wide snapshot. Resolution runs under the same owner that acquires and retires the connection.

Add the runtime-only resolve_mcp_servers constructor callback, an async (workspace: str) -> Mapping[str, OmpMcpServer]. Call it with the claimed room workspace before creating an overlay or process, and use the same snapshot for the overlay and native readiness checks.
Treat the result as the complete external server set, including an empty mapping. Resolution errors fail startup without falling back to static external entries. Live connections reuse their snapshot; a new connection resolves afresh.
Preserve the configured band endpoint alongside the resolved external set, and reject resolver results that use that reserved name. Keep provider-environment precedence, owner-only overlays, relative workspace paths and session restoration intact.
Join overlapping retirement requests and wait for the active turn's finalization, not its caller's unrelated later work. A result returned after retirement or cancellation cannot launch a process; cancelling a cleanup waiter does not cancel shared retirement.
Retain the native handle, overlay and exclusive workspace claim when native close fails. Cleanup and the next turn retry close before releasing resources or starting a new process; retiring sessions never receive new work.

Depends on #763. This does not extend retry guarantees to arbitrary overlay-deletion callback failures.

Validation

Regression coverage includes credential rotation between connections, live-session reuse, empty/error results, matching readiness snapshots, reserved Band names, restored sessions, shutdown during resolution, deadline/cancellation races and failed-native-close retries.

…porter

Give the repeated tool-completion and privacy checks one helper, and name the ACP call record so activity identity is not a bare tuple. Co-authored-by: Cursor <cursoragent@cursor.com>

Source-Base: 0d851ac Source-Head: 873a59a Upstream-PR: band-ai#854

Source-Base: d87d7c5 Source-Head: a72bd7e Upstream-PR: band-ai#854

…t-activity-detail-to-the-platform-INT-1744 Keep main's BackendTurns ownership of OpenCode cancellation and register the watcher as a turn worker so activity reporting outlives the handler. Reporter unit tests move to tests/runtime/workingreporter; main's workingstate package keeps the execution-level tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AgnNR4uiqD787Bg3yKdZpL

The restack merge resolved src/band/runtime/tools/agent.py to this branch's older lineage and dropped the activity observation the producer stack added: the class decorator reporting method calls and the model-tool wrapper around execute_tool_call. Native OMP work does not touch that surface; restore it from the prerequisite.

…nch)

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

Source-Base: 2dc539a Source-Head: 3bd7f14 Upstream-PR: band-ai#854

Live capture on the platform showed the OMP hooks posting tool_call activity details even when Emit.TOOL_CALLS was off: the activity channel is separate from event narration, so the hook sites need the same gate the narration already had. I-01/I-02: with tool reporting off, no tool kind or name may reach the reporter. Tests now pin the gate directly (activity follows the switch) instead of the incorrect independence premise. Co-Authored-By: Claude <noreply@anthropic.com>

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

Source-Base: 41fb96e Source-Head: 2cf7482 Upstream-PR: band-ai#854

The mask wrapper was attached only when the flag was already off, so an adapter that binds its observer before the emit sync (codex's item/started path) kept reporting named tool_calls after the choice was turned off. The observer now always wraps and reads the live flag on every report; the hook site gates on the OMP branch remain as the second guard. Red-first test: observer bound with names on, choice flipped off mid-turn, tool report must arrive nameless. Co-Authored-By: Claude <noreply@anthropic.com>

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

Source-Base: 3098914 Source-Head: 45a012b Upstream-PR: band-ai#854

F-8 closure evidence: an observer bound at turn start now reads the gate flag at report time (d764959, covered by the flip-after-binding test), and a stale continuation report after the next turn takes activity ownership is fenced before it can name anything. The two guards seal R-02 for OMP background-yield continuations; no production change is required.

bandzalkin · 2026-10-21T15:37:57Z

Closing: superseded by in-repo PR(s) #899 with the same content, one concern each and a clean single-author history.

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

AlexanderZ-Band and others added 15 commits October 18, 2026 13:33

fix: Keep working-state reporting alive through provider turns

d1419b7

fix: Preserve standalone worker binding across tool wrappers

8ec26b3

test: Avoid the E2E peer fixture reservation in runtime tests

1476457

style: Format the renamed activity platform fixture

8bfeac0

test: Use real time for randomized scheduler grace controls

a397d8c

feat: Deliver compatible activity detail through the working-state re…

0342d96

…porter

style: Format detail ownership fixture parameters

d76f571

test: Avoid reserved peer fixtures in activity wire tests

1842638

test: Preserve backlog ordering across valid recovery retries

06d8124

feat: Map provider and Band tool progress to room activity

2d69703

test: Validate activity producers through real execution boundaries

64de362

refactor: Consolidate activity reset and streaming usage ownership

831b851

test: Register live activity cells and disambiguate runtime fixtures

9d7fc64

fix: Fence housekeeping activity and clean up cancelled tool starts

eb7326e

refactor: Share activity observation records and assertions

a674b67

Give the repeated tool-completion and privacy checks one helper, and name the ACP call record so activity identity is not a bare tuple. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 19, 2026

feat(mcp): resolve room-scoped servers at native OMP connection startup

18b0263

Source-Base: 0d851ac Source-Head: 873a59a Upstream-PR: band-ai#854

bandzalkin force-pushed the feat/omp-owned-mcp-resolver branch from 873a59a to a72bd7e Compare October 20, 2026 06:36

bandzalkin requested review from AlexanderZ-Band and amit-gazal-band as code owners October 20, 2026 06:36

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 20, 2026

feat(mcp): resolve room-scoped servers at native OMP connection startup

0e8c023

Source-Base: d87d7c5 Source-Head: a72bd7e Upstream-PR: band-ai#854

bandzalkin added 4 commits October 21, 2026 02:30

Merge band-ai#874 (event-echo fix on the activity stack)

4f471d2

Merge band-ai#763 (event-echo fix through the stack)

58c44d7

Merge band-ai#763 (tool activity reporting restored on the native bra…

219fd49

…nch)

bandzalkin added 4 commits October 21, 2026 02:50

style: drop merge-seam blank lines from the reporter files

d697f43

Merge band-ai#841 (format fix on the activity stack)

89dab59

Merge band-ai#874 (format fix through the activity stack)

2dc539a

Merge band-ai#763 (format fix through the stack)

3bd7f14

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

feat(mcp): resolve room-scoped servers at native OMP connection startup

e37f090

Source-Base: 2dc539a Source-Head: 3bd7f14 Upstream-PR: band-ai#854

sim-artifacts and others added 2 commits October 21, 2026 05:42

Merge band-ai#763 (activity emit-gate fix) into band-ai#854

2cf7482

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

feat(mcp): resolve room-scoped servers at native OMP connection startup

04334e7

Source-Base: 41fb96e Source-Head: 2cf7482 Upstream-PR: band-ai#854

bandzalkin and others added 3 commits October 21, 2026 08:12

Merge band-ai#874 (live tool-name gate) into band-ai#763

3098914

Merge band-ai#763 (tool-activity gate cascade) into band-ai#854

45a012b

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

feat(mcp): resolve room-scoped servers at native OMP connection startup

2b6ce33

Source-Base: 3098914 Source-Head: 45a012b Upstream-PR: band-ai#854

bandzalkin added 2 commits October 21, 2026 10:27

Merge band-ai#763 (continuation gate guard) into band-ai#854

0b834e7

bandzalkin mentioned this pull request Oct 21, 2026

feat(omp): resolve room-scoped MCP servers at native startup #899

Draft

bandzalkin closed this Oct 21, 2026

Navigation Menu

Repository navigation

feat(mcp): resolve room-scoped servers at native OMP connection startup - #854

feat(mcp): resolve room-scoped servers at native OMP connection startup#854
bandzalkin wants to merge 75 commits into
band-ai:mainfrom
bandzalkin:feat/omp-owned-mcp-resolver

bandzalkin commented Oct 19, 2026 •

edited

Loading

Uh oh!

bandzalkin commented Oct 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bandzalkin commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

bandzalkin commented Oct 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bandzalkin commented Oct 19, 2026 •

edited

Loading