Repository navigation
feat(omp): resolve room-scoped MCP servers at native startup - #899
Draft
bandzalkin wants to merge 1 commit into
Draft
bandzalkin wants to merge 1 commit into
bandzalkin wants to merge 1 commit into
Conversation
bandzalkin
force-pushed
the
feat/omp-native-room-scoped-mcp-servers-INT-1892
branch
from
October 21, 2026 15:35
126ed3f to
0a4c2de
Compare
bandzalkin
added this pull request to stack #903
October 21, 2026 15:41
bandzalkin
force-pushed
the
feat/omp-native-room-scoped-mcp-servers-INT-1892
branch
from
October 21, 2026 16:13
0a4c2de to
c04a679
Compare
bandzalkin
added a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 12cff7a Source-Head: c04a679 Upstream-PR: band-ai#899
bandzalkin
force-pushed
the
feat/omp-native-room-scoped-mcp-servers-INT-1892
branch
from
October 21, 2026 17:52
c04a679 to
a71f900
Compare
A host can now pass resolve_mcp_servers, an async callable from the claimed room workspace to the room's complete external MCP server set, called once per new native process before the overlay or process exists so the overlay and the startup receipt check share one snapshot. The configured Band endpoint is kept beside the resolved set and a resolver may not claim its name. Room retirement joins overlapping cleanup calls, cancels only the room's active turn, and keeps a room whose native close failed owned until a later close succeeds.
bandzalkin
force-pushed
the
feat/omp-native-room-scoped-mcp-servers-INT-1892
branch
from
October 21, 2026 17:56
a71f900 to
8b47f8e
Compare
bandzalkin
added a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: ae28e96 Source-Head: 8b47f8e Upstream-PR: band-ai#899
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: ae28e96 Source-Head: 8b47f8e Upstream-PR: band-ai#899
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: ae28e96 Source-Head: 8b47f8e Upstream-PR: band-ai#899
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: ae28e96 Source-Head: 8b47f8e Upstream-PR: band-ai#899
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A host running the native OMP adapter needs each new room process to start with the room's current external MCP servers and credentials, not a static adapter-wide snapshot, and resolving them must run under the same owner that acquires and retires the connection.
What
resolve_mcp_servers, an async(workspace) -> Mapping[str, OmpMcpServer], called once per new room process with the claimed workspace, before the overlay or process exists; the same snapshot feeds the overlay and the startup receipt check. Its result is the complete external set (an empty mapping means none); an exception fails startup with no fallback.bandendpoint is kept beside the resolved set; a resolver may not claim that name.on_cleanup/cleanup_allcalls, cancels only the room's active turn, waits for that turn's finalization, and keeps a room whose native close failed owned until a later close succeeds.Scope
Stacked on the native adapter PR. Native OMP only; the ACP resolver is #896. Replaces #854.